If a theme has been set to Never warn if out of date and this is the latest version, it's still shown under Available updates. This can only be wrong.

Comments

Wolfgang Reszel’s picture

I confirm this behavior. I also don't see the comment.

gateone’s picture

Priority: Normal » Major

Can confirm throughout all of our installations of Drupal, too. I pumped it up to major because in environments with multiple administrators, this had already led to mistakenly updating a module that was marked as "Never" because of a major issue with that particular module update.

Anonymous’s picture

Issue summary: View changes

Same here.

Edit: Actually, the report works as expected: admin/reports/updates. The problem is that I usually use admin/modules/update to check updates. This list is much more compact. This module should alter this listing as well.

liza’s picture

same here and not just with themes. it's happening with all modules even if they are up-to-date.

attisan’s picture

fixed it - and as I'm still not best friends with creating a patch file:

add to update_advanced.module

/**
 * Implements hook_update_projects_alter().
 */
function update_advanced_update_projects_alter(&$projects) {
  update_advanced_update_status_alter($projects);
}

hth,

attisan

attisan’s picture

Assigned: Unassigned » attisan
Status: Active » Needs review
StatusFileSize
new797 bytes
trevorw’s picture

Patch works for our needs. Thanks.

klonos’s picture

Just to get this straight...

My issue is also with the email notification sent out that includes projects that are ignored along with the ones that do have updates. Is the patch in #6 above meant to address that too?

aohrvetpv’s picture

Version: 7.x-1.0-rc1 » 7.x-1.x-dev
StatusFileSize
new557 bytes

#6 works by preventing the recommended version from being set for an ignored project, which causes the page callback for admin/modules/update to skip over listing the project. However, #6 causes update_advanced_update_status_alter() to be called twice for admin/reports/updates (and perhaps other pages), which is undesirable.

This patch accomplishes the same, I believe, but without causing update_advanced_update_status_alter() to be called twice.

Note that both #6 and #9 remove the recommended version display on admin/reports/updates. For example, if you are on Foo 7.x-1.0 and ignore Foo 7.x-1.1, after this patch it will no longer say "Recommended version: 7.x-1.1 (2015-Jan-01)".

aohrvetpv’s picture

My issue is also with the email notification sent out that includes projects that are ignored along with the ones that do have updates. Is the patch in #6 above meant to address that too?

No, I don't think so. The patch in #6 changes how the "Update" tab of the "Available updates" page comes up with its list of updates. It does not change how the Update module determines whether to send an e-mail notification. Your problem probably deserves a separate issue.

Leeteq’s picture

Ref. #1273932: Continuing to alert of security updates even when the actual version is marked as ignored

"marking a module as "never inform" or "not version x", should have the same effect; stop informing specifically.

I would still like to see the version numbers listed on the modules page, but not as "alerts" when that particular version is set to be ignored, or not alert at all (with color background, etc.) for modules that is generally set to "never", regardless of version number."

The filter "ignored from settings" is useful. However, I think it should have the opposite effect on the main updates page for its default filter when this module is activated..:

Then, when filtering by that option, it would THEN be ok to have the security updates actually marked red etc. Just not on the main page when the main point is to actually NOT be "disturbed" by those colorings.

Btw, the filter options on the main updates page (All, Update available, Ignored from settings, Security update, Unknown) are not showing in all admin themes. Is that a bug of this module? Any admin theme should render those filter settings as part of the page, I think - leading me to assume that is something that should be fixed here. The RootCandy theme (still only in -dev version for 7.x is one example that does not show those filters).

Leeteq’s picture

With this module enabled, i would like this module to stop coloring updates that are specifically marked as "ignored" and also any project that is set to "never". That is for the default view of the main updates page.
However, when selecting the filter "ignored from settings", it would be ok to show only those modules, but then with the normal coloring, red for security updates, etc.

Maybe we could have an extra filter called "custom default filter", and an option on the settings page to select which of the filters should be the default one?