This task is blocking #1986990: PMProject Migrating to Node grants and similar access patches that depends on Project Management {Node Type}: {action} if assigned to Project.

CommentFileSizeAuthor
#1 PMPerson-pmteam-user-data-fix-1998072.patch984 bytesd34dman

Comments

d34dman’s picture

d34dman commented
Status: Active » Needs review
StatusFileSize
new PMPerson-pmteam-user-data-fix-1998072.patch984 bytes

Note to testers:
The working on the patch could only be confirmed by calling _pm_user_load(); function. So it is outside the scope of normal testing.

About the patch:
This one loads team data into user profile just like pmorganization_nid and and pmperson_nid. It also checks using module_exists that if pmteam module is present.

dbt102’s picture

dbt102 commented

Patch applied cleanly. Created, deleted, viewed teams using different users scenarios and no errors were observed.

Not sure what else to test for.

dbt102’s picture

dbt102 commented

After, rereading about the plan outlined at #1986990-17: PMProject Migrating to Node grants , and @D34dMan statement above

So it is outside the scope of normal testing.

I'm not sure if this means patch is RTBC because it can't be tested for, needs testing similar to that done for PMPersons but modified for teams, or testing can only be done by programmer.

I'm available to help with this, but need some direction if possible.

d34dman’s picture

d34dman commented

This one is for maintainer's review ( if you had not noticed, am not a maintainer :P ). There are multiple ways to solve the issue and provided patch is the one that agrees more to the current implementation.

Thanks for testing the patch.

I will be busy for another week and after that i would be resuming with patches. But am available for any clarifications or comments on issues.

d34dman’s picture

d34dman commented

P.S. This one is on the lines of quick fix. The long term fix as i suggested in #1986990-17: PMProject Migrating to Node grants would need some migration support code too. So it may take longer than expected.

dbt102’s picture

dbt102 commented

@D34Man - Thanks for the clarification on testing this one.

Also special kudos to you! (And also @juliangb of course ; ) ... I appreciate the commitment you've made towards programming and advancing PM module thus far. I think you're efforts have helped substantially towards the rise in "reported installs" over the last couple months. I think it will especially spike when we can get out a stable release.

I look forward to helping out as I can as we move forward.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Sorry I have been absent from the queue for a few days due to moving house.

Thanks for continuing to push and test these patches. I totally echo the comments that the progress over the last couple of months has been outstanding, hence the steady increase in usage.

I've committed this patch, with only a minor change for code style.

d34dman’s picture

d34dman commented

Thanks for the kind words, but i must disagree. I believe advertising done by juliangb, is the main reason why we have more installs.

Anways thanks for committing the patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 0154163 on 7.x-1.x, 7.x-2.x by juliangb: 
    Issue #1998072 by D34dMan: PMTeam: Changes required for access module to...