Line 242 of OverviewTerms.php results in 'taxonomy/term/()' always being returned.

CommentFileSizeAuthor
#6 1998258-6-taxonomy-term-overview-link-pass.patch1.57 KBnick_schuch
#2 1998258-2-taxonomy-term-overview-link-fail.patch867 bytesnick_schuch
#2 1998258-2-taxonomy-term-overview-link-pass.patch1.57 KBnick_schuch

Comments

nick_schuch’s picture

nick_schuch commented

I have tried to find an active issue but cannot. Currently writing tests.

nick_schuch’s picture

nick_schuch commented
StatusFileSize
new 1998258-2-taxonomy-term-overview-link-pass.patch1.57 KB
new 1998258-2-taxonomy-term-overview-link-fail.patch867 bytes

I have supplied 2 patches. One to confirm the fail and another to fix it.

nick_schuch’s picture

nick_schuch commented
Status: Active » Needs review
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Yeah, I broke that :(

looks good.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs work

Oh, not quite yet.

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Tests/TermTest.phpundefined
@@ -323,6 +323,10 @@ function testTermInterface() {
+    $this->assertResponse(200, 'Term page can be accessessed via the listing link.');

a few s and e's too much :)

nick_schuch’s picture

nick_schuch commented
Status: Needs work » Needs review
StatusFileSize
new 1998258-6-taxonomy-term-overview-link-pass.patch1.57 KB

Oh! Woops :)

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Now we're good. Let's get this in.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Nice catch and nice to have a test...

Committed 68ee461 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.