Add "Exception day" feature

I think this is covered in #1743366: [Season Meta] Add "Seasonal Hours / Duration" feature

As a work-around, I added a text field to my node type, which describes the exceptions.

See #1743366: [Season Meta] Add "Seasonal Hours / Duration" feature

I'm sorry to re-open this post. I think what adelka wants, is to add an exception date to the listed opening hours. It is not impossible to achieve this with the solutions found in #1743366: Add "Seasonal Hours / Duration" feature, but then you're supposed to make for each holiday a field collection. I was just wondering if it would be possible to maybe add an 'exclusion' sub-field where you can specify a certain date (e.g. 24/12/2014)?

check fork: https://www.drupal.org/project/opening_hours

See both linked issues for D7 and D8. It adds a 'comment' column to each time slot.
Perhaps, we can build upon that.

Pushing to D8.
ITMT, both D7 and D8 versions have a 'comment' field on each time slot. That might suffice for some use cases.

Another workaround would be to provide an alter hook. In my current case i would be able to alter the results and exclude dates from another field on the same entity.

I ended up writing a patch for my current use case. It uses a date field on the same entity to exclude holidays completely. Specifying special office hours is not possible.

We could extend this feature by making the date field configurable. This is currently hard coded.

Another limitation is that the patch only performs it's logic if the "Show next open day" display is used.

I guess there are some coding issues in this patch... I needed a quick fix :)

To make this more generic, I think it would be better to be able to add individual exception days with different start and end dates. If the values are empty, then it would mean closed. These could be optionally invisible for the user, so that the hours would just display differently on the exception days.

Even better if the actual values would change based on some exception rules. For example we have services indexed in Elasticsearch, saving the entities would index them automatically also.

So I started working on a patch, there is still a lot to do but it's starting to take shape I think. Let me know if something goes in the wrong direction or if you have any tip.

The current table holds the day in a `int` column with a length of 11, so that is perfect to store the timestamp of the exception days. So instead of creating a new Field type and all the other things I took the following approach:

- Reuse most of the existing field & features
- Create a submodule "office_hours_exceptions" so that this feature stays optional
- We store the week days from 0 to 6 as current implementation, and add exceptions as timestamp
- We add a formatter based on the table one

Eventually there is still no tests, validation is not done, and data is not 100% correctly saved. For instance if you add an exceptions with just one slot (a start and end hour) it will be stored 3 times if there is a max 3 slots.

You can see how it looks in the backend here: https://www.drupal.org/files/issues/2018-05-07/drupal-office-hours-excep...

Here is a new patch, this time basic features works good I think. For this patch I also included the one in https://www.drupal.org/project/office_hours/issues/2860041#comment-12543759 since special hours are most of the time for closed days. With the patch it saved correctly the data but I needed to add some logic to display correctly the labels and the "Closed" element.

Here are a few things which still need to be done:
- validation
- tests
- schema handling
- it's only implemented for the table formatter
- the "closed" or "isOpen" and most of the logic in OfficeHoursItemList is still untouched

Sorry, patch in 12 was wrong.

@idflood after I applied the patch, the widget was not working properly and AJAX was throwing errors. I made a couple changes after which it started working.

Attaching the new patch & interdiff.

It would be great if the exceptions are being mixed up in the hours so that they are actually changed to the exception dates.

The patch in #14 does not apply to dev anymore.

Hi @anruether

I've re-roll patch #14.

Cheers

Hi together

i added some fixes and improvements to the patch

- fixed isOpen/isClosed logic to also taking the exception days into account (only the closed open batch above or below the list)
- show only exception in the future
- configuration of the days in the future we want to display the exceptions (like: next 7 days)

Added a fix for 18 to be able to handle more exception slots in a day.

Add check for empty exceptions to prevent php warnings.

We found a bug, when a exception day is completely closed, then the status text still shows as open.
Corrected that with this patch.

I changed the 'Add element' to 'Add exception'. The button wasn't very clear to me. That also solved a problem with conflicting translation strings.

Whoops. That actually didn't change the "Add element' button to "Add exception". This does.

We have a university library with seasonal hours and MANY exceptions. We used this module in D7 and are trying to use it in D8, but it isn't working for us the way that we are doing it. I know there was talk of field collections (obsolete) and paragraphs in https://www.drupal.org/project/office_hours/issues/1743366, but no movement in a couple years.

I created an hours entity with a single paragraph field with these fields:
Label (ie. 'Fall Hours')
Date Range (when the hours are relevant)
Hours Field

I create a paragraph and include an hours field, the "Copy Previous" doesn't work at all for exceptions.

When I create a second paragraph and include several exceptions (again, copy previous does not work), and save, and go back into the entity, all exceptions in the second paragraph are deleted.

Using D8.8.1, and using patch #23 here, and #7 from https://www.drupal.org/project/office_hours/issues/3065611#comment-13396155

I'm finding if I bring these hours into views (which I'm trying to do to allow multiple blocks of hours ie. Fall Hours, Winter hours), exceptions are not working properly.

When I choose to set Number of days to show to "Show all days", and formatter to "plain text", there is no distinguishing between exceptions and normal hours. Output looks like this (just showing a normal day, and one exception):

<div class="office-hours__item">
      <span class="office-hours__item-label" style="width: 7.2em;">Saturday: </span>
      <span class="office-hours__item-slots"> 10:00 am-12:00 am</span>
      <span class="office-hours__item-comments"></span>
      <br>
    </div>
      <div class="office-hours__item">
      <span class="office-hours__item-label" style="width: 7.2em;">2020-01-02: </span>
      <span class="office-hours__item-slots"> 8:00 am-5:00 pm</span>
      <span class="office-hours__item-comments"></span>
      <br>
    </div>

If I set formatter to "table with exceptions", it doesn't display the exceptions at all.

When I have a day with an exception on it, and i set Number of days to show to "Show only current day", it doesn't show me the exception day, it shows me the hours set on the normal hours schedule.

@suegmune The path the maintainer chose is clearly not using paragraphs. I have a very specific implementation for my use case using paragraphs, but it has a lot of flaws...

I'd suggest not to take your own route, but to help get this patch working.

Created a new patch.

Changes:
* Removed cck migration, to focus purely on the field itself (please create new ticket if needed)
* Fixed some parts to make it work with version 1.3
* Replaced t() functions
* Fixed a lot of code style issues, the module has a lot of them, but I tried to make this code easier/faster to understand.
* Restored issue summary

Todo:
* Make the code smarter, lot of copy/past code from the module itself
* Remove unclear commented code

Any feedback is welcome!

I've add the same empty-check as made in https://www.drupal.org/project/office_hours/issues/3180379 for when the time is set to 0:00.
Also added limit validation errors to the 'Add exception'-button, because it was validating the whole form instead of just adding another row.

And I noticed another error which would convert the exception days to time twice. This resulted in an incorrect value and a query exception.

Updated the patch a bit to fix the drupal 9 compatibility issues

Great, thanks for your work. I tested the patch and it is missing some important elements.

In the screenshot, i need a start date and an end date (eg for holidays). I think we should add "Add date slot", with an end date.

In the timetable rendering, the dates are not displayed and it is inconsistent.

Would it be possible to display a status. That could be used in views or a custom module.

Example : I have a store and its owner is on vacation.
A warning message (a view block) might be displayed in the store.
A custom module could temporarily disable sales (the add to cart button) depending on the status.

Example : a pickup relay contrib module, could offer in the purchase tunnel, the pickup relays available using this module.

Example : the Group module could refuse new member requests during unavailability dates

While trying to figure out how the Office hours exceptions submodule works I hit two errors (see the screenshot attached).

Fixed these errors just to simplify further work on the submodule.

Fixed the patch since it broke between the 8.x-1.2.0 and 1.3.0 release.

Re-rolled specifically for the 8.x-1.3.0 release.

Also should mention what broke between 1.2.0 and 1.3.0 -- clicking on the "Add Exception" button results in nothing happening.

Error in the console window:

Uncaught Drupal.AjaxError
message: "\nAn AJAX HTTP error occurred.\nHTTP Result Code: 200\nDebugging information follows.\nPath: /node/68542/edit?ajax_form=1\nStatusText: OK\nResponseText: \nNotice: Undefined index: #hour_options in /Users/home/project/web/modules/contrib/office_hours/src/Element/OfficeHoursDatelist.php on line 109.
Error: Unsupported operand types in Drupal\\Core\\Render\\Element\\Select::processSelect() (line 152 of /Users/home/project/web/core/lib/Drupal/Core/Render/Element/Select.php)
name: "AjaxError"
__proto__: Error at http://web.lvhn.localhost/core/misc/ajax.js?v=8.9.14:100:32 at http://web.lvhn.localhost/core/misc/ajax.js?v=8.9.14:644:3

Third time is a charm. Forgot to commit the actual bug fix.

The following should be added, according to #3216490: Check "Exception day" is empty :

diff --git a/js/office_hours.js b/js/office_hours.js
index 12159f6..244dadd 100644
--- a/js/office_hours.js
+++ b/js/office_hours.js
@@ -31,6 +31,10 @@
         $(this).parent().parent().find('.form-text').each(function () {
           $(this).val($('#target').find('option:first').val());
         });
+        // Clear the date in Exception Days (add-on).
+        $(this).parent().parent().find('.form-date').each(function () {
+          $(this).val($('#target').find('option:first').val());
+        });
         // Hide the link.
         $(this).hide();
       });

Did a quick re-roll of #38, with the changes suggested in #41.

provided patch is empty, because I forgot a > in the git diff command... in #44 the patch does have some contents :)

@SpadXIII, the patch is empty :-(

oops! reposting the patch

The latest changes in the module and the latest patches aren't working properly just yet. I'm looking into figuring out what and how.

Here's a new patch, with the changes correctly applied and looks to be working fine as well.

Apologies for butchering some of the code here. I ran all the files in the modules/office_hours_exceptions directory through a code sniffer and fixed all errors and warnings. I hacked together a few things in order to get working a use case that was not working:

If a user enters in an exception row with a date but no start or end time. The behavior should be that the exception date is by default closed and appears on the node display as closed. Also, when going back to the node edit view, the exception row should display as inputted. I was seeing the correct values in the database but not in either the node display or node edit form display.

I made a lot of changes to the js/office_hours.js file to get the "Copy previous day" functionality working. I have not tried the patch from comment 46 to see if that fixes it.

I am also working on the patch #46. mostly removing removing code by not copying code, but subclassing. The current code is very much outdated.
However, It seems I broke some stuff, so i will start again with $48.

@SpadXIII,
I now see that your patch #42-#$46 are very much different from the other chain of patches. What is your source?
For instance, the main patch has a submodule. Yours has not.

[EDIT] I see, your source is #38, given your interdiff. Indeed, a submodule might not be needed.

Please find attached a reworked version of #46 (not #47).
It merely removes code, by not copying files, but subclassing existing classes.
I was not aware that #46 was not a main-stream patch. I assume/hope that the contents of the files is identical.

Are we sure we need a new submodule?

I picked the patch in #38 indeed and was surprised the submodule to be removed.
For functionality it's not needed, but on the other hand it might be nice and easy way to disable/remove the functionality by having it in a submodule.

I found a minor bug in patch 46 that makes the exception table output all exceptions regardless of setting due to it returning $element before actually processing any of them in the viewElements function.

Rerolled that patch to actually apply.

It seems we now have a Fork. Let's agree on the patch to work with.
It seems patch #47 is the last patch from the 'submodule'. Let us use that one. That is the one most ppeople work with.
@josh.fabean, can you re-work #47?
@SpadXIII, do you remember if you add some features, bug fixes, in your patch?

Some remarks on the current status (based on the 'wrong' patch #46):
- As a maintainer, I am not very keen on having a submodule in such a small module. So, in the end, I guess this will disappear in favour of some setting.
- The patch also makes the current Formatter working with dates, so a separate formatter might not be needed.
- The migrate file (last file in the patch) can be removed in the next patch, as @ethomas08 already stated. This is already in the project via another separate ticket. The file dates back from #11, three years ago.
- I will again rework the patch, to remove duplicated code, and subclass where possible.

BTW,
isn't it possible to add a 'date range' to this feature?

Please find attached a new patch.
- Some code was replaced by subclassing;
- Some code parts from #47 are removed/commented out, since it does not have the desired effect;
- I did not check the Formatters. The standard table/PlainText formatters work just fine (Except for the extra options, ofcourse)
- Javascript is not working as desired.
- Ajax callback was removed, since it makes the [Add exception] button not working. Perhaps is should be re-added.

The attached patch now has working js links again, after removing the ['day']['day_index'] part of the widget.
The ExceptionsFormatterStatus is removed, since the normal one works fine.
The ExceptionsFormatter is shorter, but in the process, I removed the special 'exceptions days' markup. Please check the result.
The ExceptionWidget is renamed to ExceptionsWidget (mind the 's'), so you'll need to remove this file, too.

Can someone upload a screendump of the Formatter from before this patch?

@ethomas08, regarding your comment #47, 'to get the "Copy previous day" functionality working'.

I guess your js code is outdated, due to the removal of [day][day_index] structure. js is now working better than before.
probel is that we are now mixing the 'week' widget for weekdays with the 'list' widget for dates.
I porpose you join forces in #3219980: Improve "Copy previous day" functionality to List Widget for the js part.

@johnv, wow, I am so excited to see all the work on this issue in just 2 weeks! I haven't had time to try any of the new patches yet but have high hopes. Thanks for pointing me to issue 3219980.

Please find attached a new version with fewer code (thanks to some technical code changes in the standard code base).
It took me a very long time, due the difficult FORM API behaviour.

Some open issues:
- as told, the Formatter from #46 is now empty, removed OfficeHoursExceptionsFormatter::viewElements().
- having a 'closed' exception day without hours ánd without comment is still not possible.
- some js-links are not hidden/displayed properly.
- more testing/fixing is needed in the UX.
- the saved day is now strtotime('some day midnight')

This patch still does not facilitate #1743366: [Season Meta] Add "Seasonal Hours / Duration" feature.
(How) can we incorporate that?

Added a patch building on johnv's work, hacking it to add a separate table line entry that says "Modified Hours" and only lists the exception entries that are 4 months from today's date.

It helps to git add the modules directory.

Above commit contains the /src/ code from #61, just to make way for other issues in the queue.

Comments from #61 still apply.
Attached is the remainder (/modules/ directory).

@thomas08, it did not take into account your changes. I noticed too late that this issue had updates.
I will merge your patch.

@ethomas08,
There are also changes in src/OfficeHoursFormatterTrait.php , which you do not seem to address in your comment.
I have committed the 'comment' part in #3232142: Simpler formatSlots() for comments.
I still need to figure out what the 'serialize($times' part does.

Function template_preprocess_office_hours_table() adds a separator row, but only on top of the table, in my case.

The formatter 'Table (with exceptions)' already has a setting "EXCEPTION DAYS HANDLING - Restrict exceptions display to x days in future", so the theme function should not need to handle that.

@ethomas08, indeed there was an error in Groupdays, due to this issue-commit or another.
#3232160: Fix groupDays() was committed, so your patch for OfficeHoursFormatterTrait.php is not completely handled (If my changes cater for your needs :-) )

@ethomas, this is now the theme function in fewer lines. It is nice that this is in a theme function.
IMO, we need to revisit some older patches, to see if ther is some valuable stuff in OfficeHoursExceptionsFormatter.php

diff --git a/office_hours.module b/office_hours.module
index 54543aa..77a36de 100644
--- a/office_hours.module
+++ b/office_hours.module
@@ -49,6 +49,15 @@ function office_hours_theme() {
  *   The variables array.
  */
 function template_preprocess_office_hours_table(&$variables) {
+
+  // Add a separate row to label the exceptions.
+  // Keys -7 to +7 are for sorted weekdays.
+  $exception_header['data']['label']['data']['#markup'] = 'Exception Hours';
+  $exception_header['class'][0] = 'office-hours-exception__label';
+  $exception_header['id'][0] = 'office-hours-exception__title';
+
+  $variables['table']['#rows'][8] = $exception_header;
+  ksort($variables['table']['#rows']);
 }
 

Please find current situation attached. Files have been renamed and removed.
Before contributing, please update to latest -dev versionn of mail module!

The formatter header 'Exception hours' is now back in the ExceptionsFormatterTable, using code from #70.

Lots of changes -- awesome!

I just updated to the latest 8.x-1.x-dev from commit 4199465, and now I notice I cannot leave the comments field blank if I leave my start and end times as hour: minute to hour:minute respectively. This used to display Closed automatically but now it gives me an error. If I put "Closed" in the comments field, it works, but as soon as I remove the comment, the error comes back again:

InvalidArgumentException: The timestamp must be numeric. in Drupal\Component\Datetime\DateTimePlus::createFromTimestamp() (line 201 of core/lib/Drupal/Component/Datetime/DateTimePlus.php).
Drupal\Core\Datetime\DateFormatter->format(NULL, 'html_date') (Line: 299)
Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterBase->formatLabels(Array, Array) (Line: 134)
Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterBase->getRows(Array, Array, Array) (Line: 43)
Drupal\office_hours\Plugin\Field\FieldFormatter\OfficeHoursFormatterDefault->viewElements(Object, 'en') (Line: 89)
Drupal\Core\Field\FormatterBase->view(Object, 'en') (Line: 263)
Drupal\Core\Entity\Entity\EntityViewDisplay->buildMultiple(Array) (Line: 267)
Drupal\layout_builder\Entity\LayoutBuilderEntityViewDisplay->buildMultiple(Array) (Line: 340)
Drupal\Core\Entity\EntityViewBuilder->buildComponents(Array, Array, Array, 'default') (Line: 282)
Drupal\Core\Entity\EntityViewBuilder->buildMultiple(Array) (Line: 18)
Drupal\paragraphs\ParagraphViewBuilder->buildMultiple(Array) (Line: 239)
Drupal\Core\Entity\EntityViewBuilder->build(Array)
call_user_func_array(Array, Array) (Line: 101)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 786)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 377)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 78)
__TwigTemplate_530628d0c6c41211203b4e41b723978a532d3527fc81259f7a9c875eb147c694->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('themes/custom/rcl_foundation/templates/field.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('field', Array) (Line: 436)
Drupal\Core\Render\Renderer->doRender(Array) (Line: 449)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array) (Line: 450)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 518)
__TwigTemplate_5c96537581c9e656e2b8be08af1e16a24cb01da9b256abd287f1456b12d0151e->doDisplay(Array, Array) (Line: 405)
Twig\Template->displayWithErrorHandling(Array, Array) (Line: 378)
Twig\Template->display(Array) (Line: 390)
Twig\Template->render(Array) (Line: 65)
twig_render_template('themes/custom/rcl_foundation/templates/node--hours.html.twig', Array) (Line: 384)
Drupal\Core\Theme\ThemeManager->render('node', Array) (Line: 436)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 201)
Drupal\Core\Render\Renderer->render(Array, ) (Line: 241)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 578)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare(Array, Object, Object) (Line: 132)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse(Array, Object, Object) (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray(Object, 'kernel.view', Object)
call_user_func(Array, Object, 'kernel.view', Object) (Line: 142)
Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch(Object, 'kernel.view') (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 52)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 717)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Was this intended, that we must fill in the comment when we are closed on a day?

@suegmune , please try latest dev from 15-sep. I have tested and found that the module works as expected.
Indeed there was some unexpected behaviour because of this ticket.

The Exception days can benefit from the https://schema.org/OpeningHoursSpecification, as provided via #3208978: Add schema.org/OpeningHoursSpecification microdata via Metatag+Token module

Here is a patch that fixes a lot of issues, also adds a plain text option on field display. It also allows for options under field display for title for exceptions and the date format of the exception. Lastly, it allows for for blank times to be added in exceptions list, which will show as all day, no matter delta it is placed.

Credit should also be given to https://www.drupal.org/u/igorbiki for helping with this patch.

@ebremner, thanks. It seems the patch is not again a stable code. So, the patch is bigger than needed, and I will need some time to evaluate.

@ebremner, your fix for the column header is now committed with attribution in #3260547: Fix Widget column without header.

Please find attached the resulting patch against today's latest codebase.

Regarding @ebremner's patch. Thanks again for that.

1. It adds a plain text option on field display. <-- I did not apply the OfficeHoursExceptionsFormatterDefault, to avoid an unmaintainable myriad of formatters and Widgets. We should use some decorator pattern or the ThirdPartySettings hooks from Fuild UI (https://api.drupal.org/api/drupal/core%21modules%21field_ui%21field_ui.api.php/9.2.x)
2. It also allows for options under field display for title for exceptions. --> That is applied, but please see the @todo's.
3. and the date format of the exception. --> Idem.
4. In the widget, it allows for for blank times to be added in exceptions list, which will show as all day, no matter delta it is placed. <-- This seems still to be working.

In OfficeHoursExceptionsWidget::extractFormValues, I do not understand the meaning of 'Remove empty slot for exception, which is added automatically'. I did not see a functional difference, so it was not added.

        // Remove empty slot for exception, which is added automatically.
        // This happens on select widget only.
        if ($item['day_delta'] > 0 && empty($item['starthours']) && empty($item['endhours'])) {
          unset($values_exceptions['value'][$key]);
          continue;
        }

In OfficeHoursList::validateOfficeHoursSlot, I did not apply the special error for exception days. Those should adhere to the same rules as defined in the Field Settings. This is also the case in ~isEmpty().
In OfficeHoursFormatterTrait::formatSlots(), the same. You may have empty hours, but then you must add a comment,e.g., 'open all day', 'only with appointment'.
I did not apply OfficeHoursFormatterTrait.php for the same reason.
Please check the available options in Field settings.

Please check viewElements() for the 'Exception days' title, where the looping logic is different from your patch.
Please check the @todo's in the code.

I still have to assess office-hours.html.twig

Hmm, patch did not apply. New try.

A reroll against latest code.
- Also: added 'and' label for 'more' slots, like in default widget
- Found a label error in Diff module, commented in @todo

A reroll against the latest code.
A new file Field/FieldType/OfficeHoursExceptionsItem.php is added. Code was moved in there.

The remarks from #84 still apply.

Not sure why the patch keeps getting 'Failed to Apply'.

@johnv I give a reroll on https://www.drupal.org/files/issues/2022-02-02/office-hours-exceptions-1... manually with MR style, please kindly review ;-)

@hswong3i,
thanks, can you share how to do that?

Please find a reroll attached.
The patch from @ebremner in #80 made it clear that the module needed some rework to isolate functionality into central functions:
#3262945: Introduce OfficeHoursDateHelper::getLabel()
#3261582: Reorganize isEmpty() and ItemList
It is clear to me that we cannot have a 'clean' Exceptions add-on without touching the main module.

The attached patch adds a new OfficeHoursExceptionsItem.
The central code is already updated with an ItemList::createitem() 'factory', where dynamically a Weekday or Exceptions Item is added.

Regarding #80, #85, the same still applies. Some code is removed from the previous patch since it is now in getLabel().

Another reroll, making the footprint each time smaller (see other new tickets).

- Regarding the updated 'emplates/office-hours.html.twig' file from #80, see not the reason for change.
- Next stop, trying to rework into third_party_settings.
- Next stop, investigate Smart date module

@johnv I found the reason why your patch failed to apply: are you creating it with MS Windows? That's the CRLF issue: https://unix.stackexchange.com/a/527230

I give a fix for #95 with `dos2unix` and able to apply it correctly ;-)

The exceptions are more and more incorporated in the standards module..

A reworked reroll.

As said, I do not like too many formatters/widgets, so the code has now been moved to thrid_party_settings.
I must say, It is not a much cleaner code, but we do not need separate formatters.
In the commits of the latest days some code was centralized in standard code, and was now removed from the exceptions code.

I will leave this to rest, for now.

Tweaked the patch a tiny little bit: added an 's' to the field type plugin id: id = "office_hours_exceptions",
That way it matches the field widget plugin id.

Found a little error in a namespace, that was the actual cause of the config-import-errors I was getting. Fixed in a new patch.

Patch #103 causes a WSOD after saving a node with exceptions.

Drupal 9.39
PHP 7.4
MariaDB 10.4

Steps:
Reinstall office hours module and apply patch via Composer
Structure -> Content Types -> Page -> Manage Form Display - change "Office Hours weekly" to "Office hours weekly with exceptions"
Edit page node - add an exception date / time
Click save - WSOD (node will not save)

Stack trace:

Drupal\Component\Plugin\Exception\PluginNotFoundException: The "field_item:office_hours_exception" plugin does not exist. Valid plugin IDs for Drupal\Core\TypedData\TypedDataManager are: dynamic_entity_reference, entity_revision_reference, entity_revision, entity_revision:block, entity_revision:block_content_type, ....... (Removed for length) ...... list, email, binary, integer in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 53 of /code/web/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).

I cleared the cache multiple times, checked for hook_updates() - no dice. Cannot view or edit node, it always gives the same error message as above.

Any ideas? Thanks.

(Edited) Truncated stack trace that was printing out every possible plugin. Was only able to fix by removing the patch and manually removing the database entries in node__field_office_hours and node_revision__field_office_hours.

The changed plugin ID is renamed in the annotation of this class: /src/Plugin/Field/FieldType/OfficeHoursExceptionsItem.php
but should be changed in OfficeHoursItemList (not in the patch) , line 52:

 $plugin_id = 'office_hours_exception';

hmm, I missed that one! I'll make a new patch when I get some time (should be around tomorrow morning)

Adding a diff would be helpful, too.

Fixed the other use of the plugin id and couldn't find any others anymore.

interdiff seems a bit overkill now, but somehow a big chunk has changed places.

I'm running into an issue with serializing a node which has an office hours field (with exceptions). We're using entity_activity module to track activity of the admins. This module stores a record with the node serialized to json.

If I add a node and it only has the default days, it serializes just fine. But once I add an exception to it, there's an error while trying to serialize the node.

As a test, I've added a form alter to a custom module in which I do a Node::load and then serialize the results to json using the serializer service. This is the error and trace:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function getValue() on null in Drupal\Core\Field\FieldItemList->getEntity() (line 50 of core/lib/Drupal/Core/Field/FieldItemList.php).

Drupal\Core\Field\FieldItemList->getEntity() (Line: 61)
Drupal\Core\Field\FieldItemBase->getEntity() (Line: 104)
Drupal\serialization\Normalizer\PrimitiveDataNormalizer->getCustomSerializedPropertyNames(Object) (Line: 29)
Drupal\serialization\Normalizer\PrimitiveDataNormalizer->normalize(Object, 'json', Array) (Line: 153)
Symfony\Component\Serializer\Serializer->normalize(Object, 'json', Array) (Line: 42)
Drupal\serialization\Normalizer\ComplexDataNormalizer->normalize(Array, 'json', Array) (Line: 153)
Symfony\Component\Serializer\Serializer->normalize(Object, 'json', Array) (Line: 29)
Drupal\serialization\Normalizer\ListNormalizer->normalize(Object, 'json', Array) (Line: 153)
Symfony\Component\Serializer\Serializer->normalize(Object, 'json', Array) (Line: 30)
Drupal\serialization\Normalizer\ContentEntityNormalizer->normalize(Object, 'json', Array) (Line: 153)
Symfony\Component\Serializer\Serializer->normalize(Object, 'json', Array) (Line: 126)
Symfony\Component\Serializer\Serializer->serialize(Object, 'json') (Line: 32)
sim_office_hours_form_sim_config_control_panel_alter(Array, Object, 'sim_config_control_panel') (Line: 539)
Drupal\Core\Extension\ModuleHandler->alter('form', Array, Object, 'sim_config_control_panel') (Line: 835)
Drupal\Core\Form\FormBuilder->prepareForm('sim_config_control_panel', Array, Object) (Line: 279)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 564)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 158)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 80)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 708)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Ok, it appears to be the exception-handling inside \Drupal\office_hours\Plugin\Field\FieldType\OfficeHoursItemList::createItem

I don't understand why it's done like this?

If I change the line that creates a ListItem to this, the errors seem to be gone:
$exceptions_list = OfficeHoursItemList::createInstance($field_definition, $this->name, $this->parent);

Found a little bug where the added exceptions would disappear when editing a saved node. Also the 'field_name'-property was missing from the definition, which generated quite a few warnings when saving a node.

Regarding #110:
to enable class overloading, in order to reduce code, I decided to have both items of type OfficeHoursItem ánd OfficeHoursExceptionsItem in the same ItemList.
The 'new' line is just because of lack of knowledge.
I removed reference to '$this->parent', becauase otherwise not ExceptionItems are created, somehow.

//   $exceptions_list = new OfficeHoursItemList($field_definition);
//   $exceptions_list = OfficeHoursItemList::createInstance($field_definition, $this->name, $this->parent);
      $exceptions_list = OfficeHoursItemList::createInstance($field_definition, $this->name, NULL);

Please test latest DEV version.
The submodule has been removed, since it was nearly empty, and we have a nice switch using the Widget.
Then, it seems that a module cannot create its own ThirdPartySettings, so the settings are moved into the standard settings.

Probably, you need to re-set the Exception settings !!

todo:
- config
- docu

Above commit added config schema, but there seems some error, according to 'Configuration Inspector' module. Not sure how to fix this.

@johnv This feature allows you to add exception days. But there should be a button to reverse that. Indeed, for ephemeral shops or events, they are closed all year except on certain days.

Does your patch allow:

- To add exceptional opening days. For stores, for example.
- To add exceptional closing days. For events, for example.

@zenimagine,
The module (or the new patch) does not allow #1743366: [Season Meta] Add "Seasonal Hours / Duration" feature

- To add exceptional opening days.
Yes, you need to set the proper Widget type 'Week (with exceptions). However you can set 'July 4th, 2022', but not 'July, 4th every year'.
- To add exceptional closing days.
Jein, you can allow comments in the widget, then add a comment 'except first Sunday of the month'

I do feel that the Formatter settings need a hint to the separate Widget.
Perhaps you can share a mock-up here, or in #1743366: [Season Meta] Add "Seasonal Hours / Duration" feature, or in a new ticket?

Hmm, apprently 'Closed' status avoid that the additional commit is displayed in this thread.

https://git.drupalcode.org/project/office_hours/-/commit/04e14200a903c9a...

Dear Audience,
please give your opinion in the ticket #3310038: Exception days: time should be optional

Thanks,