Links in Media Settings not working

Yes, the links in ?q=admin/settings/media give me exactly the same view as ?q=admin/settings/media itself.

PHP 5.2.5-pl0-gentoo
mysql 5.0.44
Apache/2.2.6

I'll look around and see if I find the cause.

I'm digging around, and trying to follow this - and where I'm lost is in function media_admin_from in includes/form-admin.inc
I can see that the callback to invoke the forms come inte that function as the variable $func, but whither does it go after that?

Grep tells me that the only function ever refering to media_admin_settings_form is media_media_menu, which returns it by way of module_invoke_all/media_invoke_menu. So, to me it looks like it's left dangling. Could it be that you have a local uncommited file? (Or am I truly too dense? :p )

Cheers!

Long answer (with debug info):

One piece of version info I forgot last time was:
Drupal 5.5

Anyway, I've been trying to parse this, and this is how I understand what I see:

media_invoke_menu('admin') invokes module_invoke_all('media_menu','admin')
then it checks the returned menu options, so that they are valid.

module_invoke_all('media_menu','admin') invokes hook_media_menu('admin') (right?)
in the case 'admin' part the $items array is filled with options (func, title, descr), where the func part is the only reference to the callbacks (so I gather that this array element must be matched to actually call the func).

In the case 'admin' part there is an additional part arg(3)=='derivatives', still - this doesn't mean that the media_admin_derivatives_add_form (or any other) is called, even if I add "/add" or "/edit" to the URL.

So, the array is returned to module_invoke_all, and then to media_invoke_menu, which checks the validity and returns it to media_admin_form in the file form_admin.inc

But media_admin_form drops the $func - so I guess it must be module_invoke_all that does the actual calling - but checking http://api.drupal.org/api/function/module_invoke_all/5 I can't see that it is invoking stuff from the result array.

So where is $func called?

======
When I run
grep "media_admin_settings" * -r
...it returns:
includes/form-admin.inc:function media_admin_settings_form() {
media.module: 'settings' => array('media_admin_settings_form',

The latter hit is in media_media_menu.
======

So I went one step further and changed media_invoke_menu like this:
+++
function media_invoke_menu($op, $item = null) {
global $debug_m;
$options = module_invoke_all('media_menu', $op, $item);
foreach ($options as $key => $value) {
// make sure that it matches what we're expecting
if (!is_string($key) || !preg_match('/^[\w_\-\/]+$/i', $key) || !is_array($value) || !isset($value[0]) || !function_exists($value[0])) {
$debug_m.="Unset: $key\n";
unset($options[$key]);
} else {
$debug_m.="Keep: $key\n";
}
}
return $options;
}
+++

And I added this at the bottom of media.module (to print the debug data):
+++
function media_footer($main=0)
{
global $debug_m;
return "

$debug_m

";
}
+++

Oh, and in form_admin.inc I also added:
+++
global $debug_m;
$debug_m.=print_r($options,true);
+++
right after:
$options = media_invoke_menu('admin');

Here's the result:

Keep: attach
Keep: embed
Keep: settings
Keep: derivatives
Keep: derivatives/add
Keep: extensions
Keep: types
Keep: programs
Keep: presenters
Array
(
[attach] => Array
(
[0] => media_attach_admin_settings_form
[1] => Attachments
[2] => Attachment settings
)

[embed] => Array
(
[0] => media_embed_settings_form
[1] => Embedding
[2] => For determining what is is embedded and how.
)

[settings] => Array
(
[0] => media_admin_settings_form
[1] => Settings
[2] => Description
)

[derivatives] => Array
(
[0] => media_admin_derivatives_form
[1] => Derivatives
[2] => Description
)

[derivatives/add] => Array
(
[0] => media_admin_derivatives_add_form
[1] => Add Derivative
)

[extensions] => Array
(
[0] => media_admin_extensions_form
[1] => Extensions
[2] => Description
)

[types] => Array
(
[0] => media_admin_types_form
[1] => Types
[2] => Description
)

[programs] => Array
(
[0] => media_admin_programs_form
[1] => Programs
[2] => Description
)

[presenters] => Array
(
[0] => media_admin_presenters_form
[1] => Presenters
[2] => Description
)

)

================

So, it doesn't look like media_invoke_menu is erasing stuff that should be kept. Thus my question; could it be that you have a local file that is missing in CVS?

It seems the problem is that I have caching turned off.

I replaced "if ($may_cache) {" with "if (1) {" and the menus came up!

Slight problem left: The admin menu doesn't play well with the DHTML-menu module. Having a subentry (Add Derivative) makes admin/settings/media inaccessible.

Confirming that it works nicely now! :)