Html entities are not properly loaded in xml cases
by example
aà (Atilde)
± (plusmn)
etc....

This is a message for this error:
Entity 'Atilde' not defined on line 2. Error code: 26
Entity 'plusmn' not defined on line 2. Error code: 26
There was an error parsing the XML document.

CommentFileSizeAuthor
#29 feeds_ex-decode-html-entities-d8-1998398-27.patch2.62 KBmegachriz
#28 interdiff-3102208-13-1998398-27.txt1.51 KBmegachriz
#28 feeds_ex-decode-html-entities-d8-1998398-27.patch2.62 KBmegachriz
#22 feeds_ex-decode-html-entities-1998398-22.patch39.89 KBtwistor
#21 feeds_ex-decode-html-entities-1998398-21.patch39.94 KBtwistor
#19 feeds_ex-decode-html-entities-1998398-19.patch39.94 KBtwistor
#17 feeds_ex-decode-html-entities-1998398-17.patch39.94 KBtwistor
#15 feeds_ex-decode-html-entities-1998398-15.patch39.94 KBtwistor
#13 feeds_ex-decode-html-entities-1998398-13.patch39.71 KBtwistor
#11 feeds_xpathparser-enable_to_ful_load_html_entities-1998398-11.patch1.05 KBvacho
#10 feeds_xpathparser-enable_to_load_html_entities-1998398-10.patch701 bytesvacho
#6 [feeds_xpathparser]-[enable-html-entities-load]-[1998398]-[5].patch1008 bytesvacho
#1 feeds_xpathparser-XML cases load html entities-1998398-1.patch1001 bytesvacho

Comments

vacho’s picture

vacho commented
StatusFileSize
new feeds_xpathparser-XML cases load html entities-1998398-1.patch1001 bytes

This patch solve the problem for cases XML.

summit’s picture

summit commented
Version: 7.x-1.0-beta4 » 7.x-1.x-dev
Status: Active » Reviewed & tested by the community

Hi,
Yes this patch works, please commit!
Greetings, Martijn

Status: Reviewed & tested by the community » Needs work

The last submitted patch, feeds_xpathparser-XML cases load html entities-1998398-1.patch, failed testing.

vacho’s picture

vacho commented
Status: Needs work » Needs review

#1: feeds_xpathparser-XML cases load html entities-1998398-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, feeds_xpathparser-XML cases load html entities-1998398-1.patch, failed testing.

vacho’s picture

vacho commented
Status: Needs work » Needs review
StatusFileSize
new [feeds_xpathparser]-[enable-html-entities-load]-[1998398]-[5].patch1008 bytes

this patch no problen in the name

vacho’s picture

vacho commented
Issue summary: View changes

Html entities are not properly loaded in xml cases

twistor’s picture

twistor commented
Priority: Critical » Normal
Issue summary: View changes

Can you explain the use case? XML isn't supposed to support HTML entities. It sounds like a bug in your source XML. I'm open to it, but there could be other side effects.

twistor’s picture

twistor commented
Title: Html entities » Add option to decode HTML entities in XML.
Category: Bug report » Feature request

I'm still not convinced.

vacho’s picture

vacho commented

Hi @twistor. Thanks for your comments.
In this xml example:

<node>
<p>
<codprod>1655515NAAS-1V</codprod>
<descrip>1655515 AS-1 75V a&Atilde;&plusmn;o10</descrip>
<ean>8499999488630</ean>
</p>
<node>

please see:añ
this Html Entities are: a&Atilde=aÃ, &plusmn=±

Because why the client and generates its data. It's something we do not always have control, and I guess it's technical information. But we can retrive and store them.

vacho’s picture

vacho commented
StatusFileSize
new feeds_xpathparser-enable_to_load_html_entities-1998398-10.patch701 bytes

Hi!!!
I update the patch for your considerations

Thanks.

vacho’s picture

vacho commented
StatusFileSize
new feeds_xpathparser-enable_to_ful_load_html_entities-1998398-11.patch1.05 KB

Hello.
I have been working on improving the script to actually support all HTML entities.

Please check this patch

twistor’s picture

twistor commented
Project: Feeds XPath Parser » Feeds Extensible Parsers
Component: Code » XML parser
Assigned: vacho » twistor
Status: Needs review » Needs work

We can't call html_entity_decode() that will break things tremendously.

I have an idea how to fix this, but no new features are going into feeds_xpathparser, so moving the issue.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_ex-decode-html-entities-1998398-13.patch39.71 KB
twistor’s picture

twistor commented
twistor’s picture

twistor commented
StatusFileSize
new feeds_ex-decode-html-entities-1998398-15.patch39.94 KB

Use the built-in map if available.

Status: Needs review » Needs work

The last submitted patch, 15: feeds_ex-decode-html-entities-1998398-15.patch, failed testing.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_ex-decode-html-entities-1998398-17.patch39.94 KB

Status: Needs review » Needs work

The last submitted patch, 17: feeds_ex-decode-html-entities-1998398-17.patch, failed testing.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_ex-decode-html-entities-1998398-19.patch39.94 KB

Sigh.

Status: Needs review » Needs work

The last submitted patch, 19: feeds_ex-decode-html-entities-1998398-19.patch, failed testing.

twistor’s picture

twistor commented
Status: Needs work » Needs review
StatusFileSize
new feeds_ex-decode-html-entities-1998398-21.patch39.94 KB

wow. such fail.

twistor’s picture

twistor commented
StatusFileSize
new feeds_ex-decode-html-entities-1998398-22.patch39.89 KB

We shouldn't decode quotes and apostrophes.

  • twistor committed 3da9110 on 7.x-1.x 
    Issue #1998398 by twistor, vacho: Add option to decode HTML entities in...
twistor’s picture

twistor commented
Status: Needs review » Fixed
twistor’s picture

twistor commented
Assigned: twistor » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

MegaChriz credited Thangaraj Moorthi.

megachriz’s picture

megachriz
Primary language Dutch
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new feeds_ex-decode-html-entities-d8-1998398-27.patch2.62 KB
new interdiff-3102208-13-1998398-27.txt1.51 KB

Patch to port this to D8.

This port of this issue was started in #3102208-13: Port D7 features to D8, hence the interdiff.

megachriz’s picture

megachriz
Primary language Dutch
commented
StatusFileSize
new feeds_ex-decode-html-entities-d8-1998398-27.patch2.62 KB

Reuploading to be able to test against 8.x-1.x instead of 7.x-1.x.

megachriz’s picture

megachriz
Primary language Dutch
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Committed #29.

Switching version back to 7.x-1.x as that was the version this issue was originally reported for.

megachriz’s picture

megachriz
Primary language Dutch
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.