EntityBCDecorator::__isset is very slow [#1998684]

EntityBCDecorator chooses to call __get() if called via __isset().

This is in general a very bad idea as a lot of code relies on isset() being fast on Arrays or object properties.

In particular this is relevant to Twig, which needs a way to fast check if a property exists or not.

For 12 nodes the difference is around 0.9ms, which are unnecessary.

See: http://www.lionsad.de/xhprof-kit/xhprof/xhprof_html/?symbol=Drupal%5CCor... for an example.

I think it at least could call the isset() function of EntityNG, though I do not much about EntityNG, yet to know if that would be feasible.

Comments

Comment #1

pancho

UTC+2 🇪🇺 EU

commented 30 June 2013 at 02:10

Thanks for reporting, but citing Berdir in #1917378-2: Improve the comments on EntityBCDecorator, we won't bother with improving what will go away until D8 release anyway:

The class is a temporary hack until we converted everything to NG and then it will be removed again. I really don't think that we need to worry about this?

Leaving it open though, because we never know if we get everything 100% converted.