Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Better descriptions for e-mail, slogan and mission, as suggested by http://swizzy.frih.net/projects/52/drupal-usability-test-report
Comment | File | Size | Author |
---|---|---|---|
#17 | missionemail.patch | 3.03 KB | keith.smith |
#12 | field-descriptions.patch | 2.76 KB | JirkaRybka |
#8 | install.php_.patch | 1.04 KB | gaele |
#7 | system.admin_.inc_.patch | 1.88 KB | gaele |
#5 | system.admin_.inc_.patch | 1.88 KB | gaele |
Comments
Comment #1
keith.smith CreditAttribution: keith.smith commentedkewl!
-- the descriptions aren't parallel with one another (the E-mail address description should be something like "E-mail address used..." to be consistent with how we use these description texts most of the time.
--
"Your site's motto, tag line, or catchphrase (often displayed alongside the site title)" would be a bit shorter.
as would "Your site's mission or focus statement (often prominently displayed on front page)"
Comment #2
keith.smith CreditAttribution: keith.smith commentedAnd oh -- should the installer instances of these descriptions be changed as well?
Comment #3
gaele CreditAttribution: gaele commentedUpdated. Not sure what you meant with your remark about E-mail address.
Comment #4
keith.smith CreditAttribution: keith.smith commentedSorry -- I knew that wasn't clear when I wrote it.
Most often, but certainly not everywhere, the descriptions under text fields restate the "thing" being referenced, but don't do it in sentence or sentence-like form necessarily (like the other two in the patch), although we do put periods at the end of them.
So, in the above, this would be more like (just as an example):
The <em>From</em> address in automated e-mails sent during registration and new password requests, and other notifications. (Use an address ending in your site's domain to help prevent this e-mail being flagged as spam.)
Comment #5
gaele CreditAttribution: gaele commentedYou're right. Although just an example it's actually much better.
Comment #6
keith.smith CreditAttribution: keith.smith commentedhttp://drupal.org/node/199405 is an issue regarding the description of the Site e-mail field in the installer.
Comment #7
gaele CreditAttribution: gaele commentedSmall correction (site\'s)
Comment #8
gaele CreditAttribution: gaele commented... and the installer patch.
Comment #9
Gábor HojtsyPlease merge patches.
Comment #10
keith.smith CreditAttribution: keith.smith commentedIf you reroll, I still think -- as in #2 -- that the installer version of the other two descriptions need to be changed as well, for consistency.
Comment #11
JirkaRybka CreditAttribution: JirkaRybka commented- We usually use double quotes rather than escaping inside a string (fixed now)
- Rerolled into a single patch.
- New strings are nice :)
- Untested.
Comment #12
JirkaRybka CreditAttribution: JirkaRybka commentedI'll try to attach the file later.
Comment #13
JirkaRybka CreditAttribution: JirkaRybka commentedSuccessfully attached (tried that through edit on previous comment to avoid spamming here), so CNR now.
Comment #14
keith.smith CreditAttribution: keith.smith commentedOops -- ignore my comments in #2 and #10 -- I mistakenly thought slogan and mission were also on the installer page, but they are not. My bad.
Comment #15
Gábor Hojtsy$ patch -p0 < field-descriptions.patch
patching file ./install.php
patching file ./modules/system/system.admin.inc
Hunk #1 FAILED at 1078.
1 out of 1 hunk FAILED -- saving rejects to file ./modules/system/system.admin.inc.rej
Comment #16
Gábor HojtsyBTW it is good to see the spam comment toned down a bit as suggested in usability reviews. Also the placement information for slogan and mission are good improvements IMHO.
Comment #17
keith.smith CreditAttribution: keith.smith commentedRerolled.
Comment #18
Gábor HojtsyGreat, committed, thanks.
Comment #19
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.