Support from Acquia helps fund testing for Drupal Acquia logo

Comments

keith.smith’s picture

Status: Needs review » Needs work

kewl!

-- the descriptions aren't parallel with one another (the E-mail address description should be something like "E-mail address used..." to be consistent with how we use these description texts most of the time.
--

-    '#description' => t('The slogan of this website. Some themes display a slogan when available.')
+    '#description' => t('Your motto, tag line, or catchphrase. Some themes display a slogan when available (usually alongside the title of the site, so keep it small).')

"Your site's motto, tag line, or catchphrase (often displayed alongside the site title)" would be a bit shorter.

-    '#description' => t('Your site\'s mission statement or focus.')
+    '#description' => t('What your site does, its mission, or main focus. Usually themes display this before any other content on the front page and make it eye catching.')

as would "Your site's mission or focus statement (often prominently displayed on front page)"

keith.smith’s picture

Component: system.module » documentation

And oh -- should the installer instances of these descriptions be changed as well?

gaele’s picture

Status: Needs work » Needs review
FileSize
1.91 KB

Updated. Not sure what you meant with your remark about E-mail address.

keith.smith’s picture

Sorry -- I knew that wasn't clear when I wrote it.

+    '#description' => t('This E-mail address is used to send automated e-mails during registration, new password requests, notifications, etc. Ideally this e-mail address should have the same domain as this website (to lessen the risk of the e-mail being classified as spam).'),

Most often, but certainly not everywhere, the descriptions under text fields restate the "thing" being referenced, but don't do it in sentence or sentence-like form necessarily (like the other two in the patch), although we do put periods at the end of them.

So, in the above, this would be more like (just as an example):

The <em>From</em> address in automated e-mails sent during registration and new password requests, and other notifications. (Use an address ending in your site's domain to help prevent this e-mail being flagged as spam.)

gaele’s picture

FileSize
1.88 KB

You're right. Although just an example it's actually much better.

keith.smith’s picture

http://drupal.org/node/199405 is an issue regarding the description of the Site e-mail field in the installer.

gaele’s picture

FileSize
1.88 KB

Small correction (site\'s)

gaele’s picture

FileSize
1.04 KB

... and the installer patch.

Gábor Hojtsy’s picture

Status: Needs review » Needs work

Please merge patches.

keith.smith’s picture

If you reroll, I still think -- as in #2 -- that the installer version of the other two descriptions need to be changed as well, for consistency.

JirkaRybka’s picture

Status: Needs work » Needs review

- We usually use double quotes rather than escaping inside a string (fixed now)
- Rerolled into a single patch.
- New strings are nice :)
- Untested.

JirkaRybka’s picture

Status: Needs review » Needs work
FileSize
2.76 KB

File attachments are disabled. The issue directory has not been properly configured. Please contact the site administrator.

I'll try to attach the file later.

JirkaRybka’s picture

Status: Needs work » Needs review

Successfully attached (tried that through edit on previous comment to avoid spamming here), so CNR now.

keith.smith’s picture

Oops -- ignore my comments in #2 and #10 -- I mistakenly thought slogan and mission were also on the installer page, but they are not. My bad.

Gábor Hojtsy’s picture

Status: Needs review » Needs work

$ patch -p0 < field-descriptions.patch
patching file ./install.php
patching file ./modules/system/system.admin.inc
Hunk #1 FAILED at 1078.
1 out of 1 hunk FAILED -- saving rejects to file ./modules/system/system.admin.inc.rej

Gábor Hojtsy’s picture

BTW it is good to see the spam comment toned down a bit as suggested in usability reviews. Also the placement information for slogan and mission are good improvements IMHO.

keith.smith’s picture

Status: Needs work » Needs review
FileSize
3.03 KB

Rerolled.

Gábor Hojtsy’s picture

Status: Needs review » Fixed

Great, committed, thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.