Closed (fixed)
Project:
Drupal core
Version:
6.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
11 Dec 2007 at 14:45 UTC
Updated:
1 Jan 2008 at 16:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
gábor hojtsy- So is there no value in linking to the Throttle config page?
- While we are here, why not break up this long help text to t()'s per paragraph, as used elsewhere? (And as it is much easier for translators).
Comment #2
gaele commentedAt your service ;-)
Comment #3
keith.smith commentedNote that there is an older issue for block module help text, at http://drupal.org/node/189865. But, it has no patch so I'd say just close that one as a duplicate if you want to continue here.
I haven't looked at this help text in detail, but this may also be an opportunity to add text addressing the new drag-and-drop ordering functionality for the blocks page.
I just happened to notice this existing line at the bottom of the patch:
When we say "make it active and give it a place on the page", this does mean enable and position, right? It may be out of scope here, but this line looks like it could use some tweaking.
Comment #4
gaele commentedImplemented Keith's suggestions (except for the drag-and-drop description).
Comment #5
keith.smith commentedComment #6
gábor hojtsy- Thanks for breaking the big stuff up :) Although our code style requires that dots stick to the literal strings, so eg.
'<li>'.instead of'<li>' .-
position it on the page using <a href="@overview">blocks</a>? Using blocks?Comment #7
gaele commented- Adjusted to conform to code style.
- "Once you have created this block you must enable it and position it on your web pages using the blocks page." (which is consistent with the description on the blocks page itself.)
Comment #8
gaele commentedComment #9
keith.smith commentedNo patch attached. :(
Comment #10
keith.smith commentedI started putting the drag-and-drop stuff in per #4, and wound up with a wholescale rewrite.
The attached patch:
* reworks the main help text, plus the text headers over the main block pages.
* It does handle the drag-and-drop stuff, though not every eventuality (like non-js browsers, etc.)
* I put the throttle-specific help on the admin/build/block page inside a conditional so that it only appears if throttle.module exists.
* This patch uses gaele's work from previous patches to split the help text into more manageable strings for translation.
This is a major rewrite, so I'm going to expand the scope of this issue to cover the help text as well.
Comment #11
keith.smith commentedAdded a note about remembering to click Save blocks after reordering block items.
Comment #12
gábor hojtsyReading it through, it looks like a huge improvement so I committed this one. I am not sure how non-JS browsers can be accomodated here, but if you have good ideas, feel free to reopen the issue. The "when allowed by an administrator, specific blocks.." part also looked a bit strange, but I tried to come up with better wording myself, and was unable to. So feel free to submit a small improvement for that too in an issue follow up on this same issue, if you have better ideas. Thanks.
Comment #13
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.