The Magic module is home to a bunch of really nice theming tools. Some where previously in Aurora but the authors decided to move them into a separate module so that all themes can benefit from them.

Whereas I don't think there might necessarily be anything needed to explicitly "support" this module, it'd be nice to keep in mind so that we don't end up re-inventing the wheel at any point...

#2025633: Theme support for magic module. How? / Response from Maintainer of Magic Module:

1) Test: As with all things, test the module with your theme to make sure there isnt anything that we do with JS/CSS that would interfere with how you do your CSS/JS.

2) Remove duplicated settings: I am not sure about your theme in particular, but there are some that duplicate functionality with Magic. A good example is the Zen setting to rebuild theme settings. If you have something similar, it is not needed anymore within your theme. You can either remove it, or remove it selectively if Magic is enabled (as Aurora does).

3) Add issues to Magic: If you have other functionality that you feel more themes would benefit from, add an issue so we can consider adding it. 95% of Magic's functionality is taking pieces of themes that can be reused and making them available to all.

Comments

chrisjlee’s picture

chrisjlee commented

We typically try not to depend on any modules. But i think it's best to provide optional code to allow for the integration? I'll look into seeing what it takes to get it work too.

alexweber’s picture

alexweber commented

It's mostly for dev tools so viewport indicator, flushing theme registry, etc which a lot of themes implement themselves...

I've taken a look at both the Magic module itself and also the Aurora module which is the one it branched off of and is "recommended" and there's no integration that I can see.

It's more a case of not implementing these features in this theme and updating docs; ie adding a link to Magic in the project description and having the Magic module link back, similar to what Aurora does :)

kevinquillen’s picture

kevinquillen commented

One of the things mentioned in the BOF at Drupalcon was Zurb Foundation (this theme) is kind of comparable to Zen - it's a starting point without reliance on outside contrib and as little plugins possible.

If there's something we could do in the code to make it 'open' to working with Magic but not relying on it, that would be cool. Docs are forthcoming, just a lot happening at the moment trying to keep up with D8 haha.

chrisjlee’s picture

chrisjlee commented

Created issue for this #2025633: Theme support for magic module. How?. Awaiting answer.

chrisjlee’s picture

chrisjlee commented
Status: Active » Postponed (maintainer needs more info)
alexweber’s picture

alexweber commented

Good call Chris, thanks!

iamcarrico’s picture

iamcarrico commented
Status: Postponed (maintainer needs more info) » Active

Hey--- I added more info here for general usage... let me know if you have questions!

#2025633: Theme support for magic module. How?

chrisjlee’s picture

chrisjlee commented

@ChinggizKhan has provided some great feedback. I've added this to the issue summary for reference.

It looks like we don't have to do anything major to support the magic module. The only thing we're missing is testing.

@alexweber thoughts?

alexweber’s picture

alexweber commented

@chrisklee, I think that's about right (see #2) so in this case maybe we can test it and if all ok then say that we support it somewhere in docs and have the magic module's project page link to ours as a theme designed with magic in mind :)

alexweber’s picture

alexweber commented
Priority: Normal » Minor
alexweber’s picture

alexweber commented
Issue summary: View changes

Updated issue summary.

kevinquillen’s picture

kevinquillen commented
Issue summary: View changes
Status: Active » Postponed (maintainer needs more info)

Are we still doing this?

chrisjlee’s picture

chrisjlee commented
Status: Postponed (maintainer needs more info) » Postponed

Not sure. We can leave it postponed.

kevinquillen’s picture

kevinquillen commented

Okay. The latest 5.x snapshot has a more structured SMACSS approach.

kevinquillen’s picture

kevinquillen commented
Status: Postponed » Closed (won't fix)

Closing - doesn't seem like there is much demand for this anymore.