The number of nights part in the commerce_line_item label is set to maximum 30 days. If a booking is placed with 31 it starts over from 0.
I don't know if this is a bug but i have a hard time understanding the use of the current functionality.
I fixed it by changing and moving the php date/time formating on line 29-30 of rooms_booking_manager/rooms_booking_manager_commerce.inc:
- $nights = $dd->diff($agent->start_date)->d;
- $line_item_label = 'Booking for ' . $unit_type->label . ' (' . $nights . ' Nights; Arriv......
+ $nights = $dd->diff($agent->start_date);
+ $line_item_label ='Booking for ' . $unit_type->label . ' (' . $nights->format('%a') . ' Nights; Arriv.....
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | Screenshot-67.png | 55.93 KB | pozzobalbi |
| #1 | screenshot.booking_cart_dev.jpg | 63.33 KB | 1an_m |
| Rooms Cart Nights.JPG | 40.94 KB | peter.larsson |
Comments
Comment #1
1an_m commentedI can confirm this with dev version as well. This seems to be an issue with the line item label only, since the correct number of nights is used to calculate the price.
Comment #2
nicola85 commentedThe fix is this:
- $nights = $dd->diff($agent->start_date)->d;
+ $nights = $dd->diff($agent->start_date)->days;
This will be solved soon in the latest dev
Comment #3
pozzobalbi commentedBesides a calculation error when selecting a booking from 1. October 2013 to 1. November 2013 (he was calculating 1 Night - which was fixed with the fix from above), I also get an error in calculating the price for the complete stay. When calculating the total for 31 nights, he is actually giving the price for only one night.
See attachment. Unit price is 30€. This is a critical bug and present in 1.0 and 1.x-dev. Please help.
Comment #4
nicola85 commentedThe fix is this:
- $days = $event->diff()->d + 1;
+ $days = $event->diff()->days + 1;
in file rooms_pricing.unit_pricing_calendar.inc
This will be solved soon in the latest dev
Comment #5
ronald_istos commentedCode committed to master