trying to save a translation for views like here: admin/structure/views/view/frontpage/translate/edit/de does only work for "Administrative description" and "Human readable name" but not for a Display Setting like the Title of a Display.
There is no error thrown, it's just not saved. Does not work for all Views, not only the Frontpage

Comments

vijaycs85’s picture

Ok, it looks like we are loosing the structure of data in language specific file. in base file(views.view.frontpage.yml) it is display.page_1.display_title where as in language specific file (locale.config.fr.views.view.frontpage.yml) it is saved as page_1.display_title.

schnitzel’s picture

Issue tags: +Needs tests

this should be covered by tests

schnitzel’s picture

Status: Active » Needs review
StatusFileSize
new3.95 KB
new3.08 KB

found the issue, also added some tests

Status: Needs review » Needs work

The last submitted patch, 1999192-config-translastion-views-3.patch, failed testing.

schnitzel’s picture

Status: Needs work » Needs review
StatusFileSize
new2.98 KB
new3.86 KB

so this had a small issue, fixed now

Status: Needs review » Needs work
Issue tags: -Needs tests

The last submitted patch, 1999192-config-translastion-views-5-testonly.patch, failed testing.

schnitzel’s picture

Status: Needs work » Needs review
schnitzel’s picture

schnitzel’s picture

Status: Needs review » Needs work
Issue tags: +Needs tests

The last submitted patch, 1999192-config-translastion-views-5-testonly.patch, failed testing.

gábor hojtsy’s picture

Except the indentation, it looks great.

schnitzel’s picture

Status: Needs work » Needs review
StatusFileSize
new3.79 KB

new full patch with correct white space

gábor hojtsy’s picture

Status: Needs review » Fixed

Great, thanks, committed! Also fixed the remaining minor whitespace problem on the way! :)

Automatically closed -- issue fixed for 2 weeks with no activity.