After the settings are exported and imported (i.e. using Features), the widget setting for exposing all, some, or no inline fields is stored as an integer. The module currently requires that this value is stored as a string to be recognized by the logic that configures the inline editing form provided by the module.
This issue is caused by the use of === instead of == in a few places. There doesn't seem to be harm in making these comparisons non-strict, especially since the variables are also checked to exist (with isset).
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | file_entity_inline-1999336-1-settings_weak_compare.patch | 1.37 KB | arithmetric |
Comments
Comment #1
arithmetric commentedAttached is a patch that changes these comparisons to the non-strict operator.
Comment #2
ey commentedI've reviewed and tested the patch. It does simply what it promises. Please commit, this is actually a simple but an important bug.
Comment #3
gappleMarked #2369013: Incompatible with Features because of string to number conversion as as duplicate
Comment #4
juampynr commentedThis patch solved a hairy issue I was facing with Features not reverting field instance settings as expected. Thanks!
Comment #5
scottrigbyYep, was about to upload the same patch. #1 RTBC FTW.
Comment #6
delzhand commentedJust found this independently and came to submit an identical patch. Any hope of getting this committed?
Comment #7
alesr commentedIt's crazy to have issues like this and no maintainers.
We could be creating a separate github project page and fork it there but it's better to bring this project back to life.
Let's get this issue https://www.drupal.org/project/projectownership/issues/2948719 to the Drupal.org managers (IRC, etc) and sign up if you want to co-maintain it.
Comment #8
damienmckennaThis is also partly covered by #2227171: Extra fields and fields not being filtered, which also adds support for extra fields.
Comment #10
damienmckennaReviewed the changes and I agree this would be a useful change. Committed.