Use Symfony Request for locale module [#1999394]

Comment	File	Size	Author
#5	1999394-replace-raw-variables-locale-5.patch	1.85 KB	aaronott
#5	1999394-interdiff.txt	1.67 KB	aaronott
#3	1999394_3-replace-raw-variables-locale.patch	1.79 KB	chertzog
#1	1999394_1-replace-raw-variables-locale.patch	1.79 KB	chertzog

Comment #1

chertzog

he/him

English

Harrisburg, PA, USA

commented 23 May 2013 at 03:48

Assigned:	Unassigned	» chertzog
Status:	Active	» Needs review

Status	File	Size
new	1999394_1-replace-raw-variables-locale.patch	1.79 KB

Log in or register to post comments

Comment #2

23 May 2013 at 03:50

Status:

Needs review

» Needs work

The last submitted patch, 1999394_1-replace-raw-variables-locale.patch, failed testing.

Log in or register to post comments

Comment #3

chertzog

he/him

English

Harrisburg, PA, USA

commented 23 May 2013 at 03:58

Status:

Needs work

» Needs review

Status	File	Size
new	1999394_3-replace-raw-variables-locale.patch	1.79 KB

Log in or register to post comments

Comment #4

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

commented 1 June 2013 at 21:13

Status:

Needs review

» Needs work

+++ b/core/modules/locale/locale.pages.incundefined
@@ -65,17 +65,19 @@ function locale_translate_filter_load_strings() {
+      $request = $query->get($key);
+      if (!empty($request)) {

$request isn't the right variable name to use here. Let's use $filterParam instead.

Also, we can use $request->has($key) instead.

+++ b/core/modules/locale/locale.pages.incundefined
@@ -445,10 +447,10 @@ function locale_translate_edit_form_submit($form, &$form_state) {
+  $query = Drupal::request()->query->get('page');

$query isn't the right variable name to use. How about $pageParam.

+++ b/core/modules/locale/locale.pages.incundefined
@@ -445,10 +447,10 @@ function locale_translate_edit_form_submit($form, &$form_state) {
+  if (!empty($query)) {

We can use $request->has('blah');