Currently if a feature defines a 'field' but not the corresponding node type, features-update (fu) will loose the field instead of suggesting the new one.

This can be reproduced using openpublish and openpublish_article_extra_media feature (the field it defines disappears, but fu on the openpublish_article will add the field to article as node suggests that field).

Comments

hefox’s picture

Status: Active » Needs review
StatusFileSize
new2.53 KB
hefox’s picture

Tested this via fu and the ui; both recreates changed over to field_instance =)

damienmckenna’s picture

Duplicate of #1966062: Updating from older version to beta2 doesn't auto-select fields, but this has code so we'll keep it.

hefox’s picture

Bah, I *knew* I'd seen an issue about it, but failed to find it.

Grayside’s picture

Status: Needs review » Needs work

Applied the patch and tried it various ways. I'm not seeing any change in behavior.

hefox’s picture

Status: Needs work » Needs review

Make sure the field exists in the database; the old feature may need to be reverted. I tested this just now with openpublish and node-openpublish_article-field_op_caption

kristen pol’s picture

Title: Convert 'field' to 'field_instance' on feautres-update » Convert 'field' to 'field_instance' on features-update (fu)
mpotter’s picture

This definitely seems to fix the situation in #1966062: Updating from older version to beta2 doesn't auto-select fields where field_instance and field_base are not selected when the feature doesn't export the content type. Doing some more testing, but this is getting close.

mpotter’s picture

Status: Needs review » Fixed

OK, this patch is working well for me in my testing. Committed this to 156ba27. I encourage you to try it if you had missing fields when converting to Features 2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Updated issue summary.