Closed (fixed)
Project:
Drupal Commons
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 May 2013 at 12:16 UTC
Updated:
5 Jun 2013 at 22:50 UTC
Jump to comment: Most recent file
The document content type is promoted to the frontpage by default.
Patch follows.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | commons-2000702-5-document-promotion.patch | 972 bytes | BarisW |
| #1 | commons-2000702-1-document-promotion.patch | 420 bytes | BarisW |
Comments
Comment #1
BarisW commentedComment #2
ezra-g commentedThanks for the patch! Can you provide an upgrade path that updates this value for upgrading sites?
Comment #3
BarisW commentedHi Ezra,
sure, but do we want that? What if people want their Documents on the frontpage? A feature revert sets the default state back to non-promoted, but leaves current nodes untouched. Do you want me to write a script that updates existing document nodes?
Comment #4
ezra-g commentedThe general practice in Commons is to revert all exportable components to their defaults if we make changes to those exportables in the Commons codebase.
The assumption is that any site-specific changes to those defaults are exported in code, meaning a features-revert won't wipe out the site-specific settings.
Comment #5
BarisW commentedValid assumption (on my side). Patch attached.
Comment #6
devin carlson commentedThe patch in #5 applied cleanly and stopped Document nodes from being promoted to the front page by default.
Tested by installing commons, checking the publishing options for Documents, applying the patch and running the included update function and finally rechecking the publishing options for Documents.
Comment #7
devin carlson commentedCommitted to 7.x-3.x.
http://drupalcode.org/project/commons.git/commit/562340f