If you change the display name from a node type the Submitted by still shows the system name. Also, if you use system names with an underscore (project_issue), the name displayed is shown as Project_issue instead of Project Issue (or just Issue if you changed the label).

Patch follows to use <?php node_type_get_type(); ?> to display the system name.

CommentFileSizeAuthor
#2 commons_origins-2001634-2-node-type-name.patch788 bytesdevin carlson
#1 commons_origins-2001634-1-node-type-name.patch775 bytesBarisW

Comments

BarisW’s picture

BarisW commented
Status: Active » Needs review
StatusFileSize
new commons_origins-2001634-1-node-type-name.patch775 bytes

You can see it in action on the default homepage in the activity stream:

My nice node type label created by Username on Thu, 05/23/2013 - 12:42

devin carlson’s picture

devin carlson commented
StatusFileSize
new commons_origins-2001634-2-node-type-name.patch788 bytes

The patch in #1 looks and works great! It looks like the administrator-submitted node type name isn't sanitized anywhere and should be run through check_plain().

BarisW’s picture

BarisW commented

Ah mu fault, you are right. Thanks for fixing it.
Someone else wanting to review? It's a simple fix, so I'd be tempted to change it to RTBC myself, but I wont ;)

devin carlson’s picture

devin carlson commented
Status: Needs review » Reviewed & tested by the community

It's a pretty straightforward fix. :)

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed to Commons Origins 7.x-3.x.

http://drupalcode.org/project/commons_origins.git/commit/fe75127

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.