field_collection_field_widget_form() should not override default $element properties

Inspired from: #2001444: The module doesn't work with multiple Field Collections

Here is a dump $element variable from field_collection_field_widget_form().

In my case field_organizers is attached to article node type, not to field_collection_item. I think we should use default properties in $element variable.

Comment	File	Size	Author
#24	field_collection-element_properties-2001682-24.patch	1.53 KB	dshields
#21	field_collection-element_properties-2001682-20.patch	1.53 KB	dshields
#19	field_collection-element_properties-2001682-17.patch	1.52 KB	dshields
#14	field_collection-element_properties-2001682-13.patch	1.29 KB	dshields
#14	field_collection-element_properties-2001682-13.patch	1.29 KB	dshields
#12	field_collection-element_properties-2001682-12.patch	1.19 KB	dshields
#10	field_collection-element_properties-2001682-10.patch	1013 bytes	xenophyle
#1	field_collection-2001682-1.patch	1022 bytes	chi
	element-variable.png	51.42 KB	chi

Comments

Comment #1

chi commented 23 May 2013 at 13:31

Status:

Active

» Needs review

Status	File	Size
new	field_collection-2001682-1.patch	1022 bytes

Log in or register to post comments

ilfelice’s picture

Comment #2

ilfelice commented 23 May 2013 at 22:18

Thank you for looking into this!

Will try to test this patch during the weekend and report back.

Log in or register to post comments

ilfelice’s picture

Comment #3

ilfelice commented 23 May 2013 at 23:16

Chi,

Can you please confirm which version of Field Collection should patch #1 be applied against?

Thank you!

Log in or register to post comments

ilfelice’s picture

Comment #4

ilfelice commented 23 May 2013 at 23:50

I applied the patch on #1 to 7.x-1.x-dev version (2013-Apr-12), and this does seem to do the trick. There are no side effects that I can tell from quick testing, but will test a bit more and let you know.

Log in or register to post comments

Comment #5

chi commented 24 May 2013 at 02:39

Can you please confirm which version of Field Collection should patch #1 be applied against?

The patch should be applied against the most recent development version.

Log in or register to post comments

adam_b’s picture

Comment #6

adam_b commented 13 July 2013 at 11:26

Works for me against the 2013-Apr-12 dev version; no side effects apparent.

Log in or register to post comments

Comment #7

tuccio commented 29 October 2013 at 20:30

Great, thank you. Working for me with the latest 2013-Oct-10 dev release. Please commit this patch as it is necessary for the module Multiple Value Widget.

Log in or register to post comments

japicoder’s picture

Comment #8

japicoder commented 20 November 2013 at 11:22

I tested an adapted version of the patch with field_collections 7.x-1.0-beta4 and it works pretty well. This is RTBC for me and necessary to be on the module.

Log in or register to post comments

Comment #9

4 July 2014 at 08:55

ciss queued 1: field_collection-2001682-1.patch for re-testing.

Log in or register to post comments

Comment #10

xenophyle commented 1 December 2014 at 15:45

Issue summary:

Status	File	Size
new	field_collection-element_properties-2001682-10.patch	1013 bytes

New patch for latest 7.x-1.x.

Log in or register to post comments

Comment #11

9 June 2015 at 10:02

ciss queued 10: field_collection-element_properties-2001682-10.patch for re-testing.

Log in or register to post comments

dshields’s picture

Comment #12

dshields commented 7 June 2016 at 09:56

Status	File	Size
new	field_collection-element_properties-2001682-12.patch	1.19 KB

This will apply against the latest dev.

Log in or register to post comments

Comment #13

7 June 2016 at 10:01

Status:

Needs review

» Needs work

The last submitted patch, 12: field_collection-element_properties-2001682-12.patch, failed testing.

Log in or register to post comments

dshields’s picture

Comment #14

dshields commented 7 June 2016 at 10:37

Status:

Needs work

» Needs review

Status	File	Size
new	field_collection-element_properties-2001682-13.patch	1.29 KB
new	field_collection-element_properties-2001682-13.patch	1.29 KB

Sorry, don't use #12. Use this instead.

Log in or register to post comments

dshields’s picture

Comment #15

dshields commented 7 June 2016 at 10:37

1 file was hidden/shown/deleted

Status	File	Size
hidden	field_collection-element_properties-2001682-13.patch	1.29 KB

Log in or register to post comments

dshields’s picture

Comment #16

dshields commented 7 June 2016 at 10:37

1 file was hidden/shown/deleted

Status	File	Size
hidden	field_collection-element_properties-2001682-12.patch	1.19 KB

Log in or register to post comments

Comment #17

7 June 2016 at 10:45

The last submitted patch, 14: field_collection-element_properties-2001682-13.patch, failed testing.

Log in or register to post comments

Comment #18

7 June 2016 at 10:47

Status:

Needs review

» Needs work

The last submitted patch, 14: field_collection-element_properties-2001682-13.patch, failed testing.

Log in or register to post comments

dshields’s picture

Comment #19

dshields commented 7 June 2016 at 10:52

Status:

Needs work

» Needs review

Status	File	Size
new	field_collection-element_properties-2001682-17.patch	1.52 KB

I apologize for making such a mess of this thread :-)
This one actually works!

Log in or register to post comments

Comment #20

7 June 2016 at 10:55

Status:

Needs review

» Needs work

The last submitted patch, 19: field_collection-element_properties-2001682-17.patch, failed testing.

Log in or register to post comments

dshields’s picture

Comment #21

dshields commented 8 June 2016 at 10:16

Status	File	Size
new	field_collection-element_properties-2001682-20.patch	1.53 KB

Wow!
Another try

Log in or register to post comments

dshields’s picture

Comment #22

dshields commented 8 June 2016 at 10:16

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #23

8 June 2016 at 10:18

Status:

Needs review

» Needs work

The last submitted patch, 21: field_collection-element_properties-2001682-20.patch, failed testing.

Log in or register to post comments

dshields’s picture

Comment #24

dshields commented 8 June 2016 at 10:38

Status:

Needs work

» Needs review

Status	File	Size
new	field_collection-element_properties-2001682-24.patch	1.53 KB

Log in or register to post comments

Comment #25

8 June 2016 at 10:40

Status:

Needs review

» Needs work

The last submitted patch, 24: field_collection-element_properties-2001682-24.patch, failed testing.

Log in or register to post comments