Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#3 drupal-get_title-2002250-01.patch1.62 KBdwieeb
#1 drupal-get_title-2002250.patch1.61 KBdwieeb

Comments

dwieeb’s picture

dwieeb commented
Assigned: dwieeb » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal-get_title-2002250.patch1.61 KB
dawehner’s picture

dawehner
Primary language German
commented

Looks great!

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.phpundefined
@@ -926,7 +926,7 @@ function title() {
+  function getTitle() {

Please make it public

dwieeb’s picture

dwieeb commented
StatusFileSize
new drupal-get_title-2002250-01.patch1.62 KB
aprice42’s picture

aprice42 commented
Assigned: Unassigned » aprice42

reviewing...

aprice42’s picture

aprice42 commented
Assigned: aprice42 » Unassigned

not able to determine the best action for testing this. sorry.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5a95824 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.