Remove views method add_having()

Ran successful test creating a new view.

#2: views-2002270-addHaving.patch queued for re-testing.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -915,7 +915,7 @@ function add_where_expression($group, $snippet, $args = array()) {
+  function addHaving($group, $field, $value = NULL, $operator = NULL) {

Add public access modifier in front of the function to adher to the new OOP standards.

adding public access modifier

Looks fine to me now !

This function does not seem to be called anywhere... is it needed?

Yes that's true there is no place currently in core which calls this function.

To be honest I can't think of a usecase of a having expression without using a snippet (like addHavingExpression() allows you)
as you always need an aggregation function. I would go with dropping support for it.

:)

removing it

If we really see that someone is using it we can readd it. This will not break any api in the future.

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.