Rename Views method add_relationship() to addRelationship()

Missing replacement of QueryPluginBase::add_signature in core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.php

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -290,7 +290,7 @@ public function submitOptionsForm(&$form, &$form_state) {
+  function addRelationship($alias, JoinPluginBase $join, $base, $link_point = NULL) {

Add public access modifier in front of the method to adher to the new OOP standards.

Added access modifier.

Looks fine by me now !

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/field/NcsLastCommentName.phpundefined
@@ -40,7 +40,7 @@ public function query() {
-//    $this->user_table = $this->query->add_relationship(NULL, $join, 'users', $this->relationship);
+//    $this->user_table = $this->query->addRelationship(NULL, $join, 'users', $this->relationship);

+++ b/core/modules/comment/lib/Drupal/comment/Plugin/views/sort/NcsLastCommentName.phpundefined
@@ -33,7 +33,7 @@ public function query() {
-//    $this->user_table = $this->query->add_relationship(NULL, $join, 'users', $this->relationship);
+//    $this->user_table = $this->query->addRelationship(NULL, $join, 'users', $this->relationship);

I think we should be removing the commented out lines of code. That's why we have a SCM.

Re-rolled removing commented out lines and renamed add_relationship().

Arggg, sorry about the last patch, I rolled it without "git rest --hard"...

Re-roll of #8.

#9: 2002274-9-rename-add_relationship.patch queued for re-testing.

Committed 18e0327 and pushed to 8.x. Thanks!