Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 views-method_allow_advanced_render-2002356-05.patch2.49 KBSpartyDan
#2 2002356-2-rename_allowAdvancedRender.patch2.47 KBgung wang

Comments

gung wang’s picture

gung wang commented
Assigned: Unassigned » gung wang

I take it.

gung wang’s picture

gung wang commented
Status: Active » Needs review
StatusFileSize
new 2002356-2-rename_allowAdvancedRender.patch2.47 KB

Status: Needs review » Needs work

The last submitted patch, 2002356-2-rename_allowAdvancedRender.patch, failed testing.

aspilicious’s picture

aspilicious commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpundefined
@@ -89,7 +89,7 @@ public function init(ViewExecutable $view, DisplayPluginBase $display, array &$o
+  function allowAdvancedRender() {

Should be protected function ...

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/field/PrerenderList.phpundefined
@@ -114,7 +114,7 @@ function get_items($values) {
+  function allowAdvancedRender() {

Same

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-method_allow_advanced_render-2002356-05.patch2.49 KB

added protected function and re-rolled

elvis2’s picture

elvis2 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e55477f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.