Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 03:19 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
baldwinlouie commentedtaking it: baldwinlouie and sillygwailo
Comment #2
baldwinlouie commentedattaching patch
Comment #3
baldwinlouie commentedComment #5
baldwinlouie commented#2: drupal-camelcase_replace-2002368-7450032.patch queued for re-testing.
Comment #6
oenie commentedAdd protected access modifier in front of the function to adher to the new OOP standards.
Comment #7
baldwinlouie commentedre-rolling the patch
Comment #9
baldwinlouie commented#7: drupal-camelcase_replace-2002368-7.patch queued for re-testing.
Comment #11
SpartyDan commented#7: drupal-camelcase_replace-2002368-7.patch queued for re-testing.
Comment #12
oenie commentedLooks good to me now !
Comment #13
elvis2 commentedShould the access modifier on this function be protected or public?
Comment #14
heddnIf the method is only used internally i.e. $this->{foo}, then I'd recommend protected. Otherwise, go with public as it needs to be usable by folks outside the class is apart of the public API.
Comment #15
alexpottCommitted 7ab5c07 and pushed to 8.x. Thanks!
Comment #16
elvis2 commentedThis patch only changes the function from protected to public, based on #14.
Comment #17
dawehnerI don't think we need this to be public.
Comment #18
elvis2 commented@dawehner, thanks for chiming in.