Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 2002370-8.patch1.29 KBjibran
#2 views.core-rename_build_display_options-2002370-02.patch1.29 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
StatusFileSize
new views.core-rename_build_display_options-2002370-02.patch1.29 KB

Rolled patch that renames build_display_options attached.

jameswoods’s picture

jameswoods commented

Renamed functions look good to me.

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views.core-rename_build_display_options-2002370-02.patch, failed testing.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#2: views.core-rename_build_display_options-2002370-02.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll

curl http://drupal.org/files/views.core-rename_build_display_options-2002370-02.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1323  100  1323    0     0   3641      0 --:--:-- --:--:-- --:--:--  7037
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:649
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new 2002370-8.patch1.29 KB

reroll

aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
somepal’s picture

somepal commented

second review.gtg

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method build_display_options() to buildDisplayOptions() » Change notice: Rename Views method build_display_options() to buildDisplayOptions()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Rename Views method build_display_options() to buildDisplayOptions() » Rename Views method build_display_options() to buildDisplayOptions()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.

Automatically closed -- issue fixed for 2 weeks with no activity.