Rename Views method build_group_form() to buildGroupForm()

Patch applied that renames build_group_form.

Fixed the patch. Had included previous changes. Only lists build_group_form now.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -829,7 +829,7 @@ public function buildExposedForm(&$form, &$form_state) {
+  function buildGroupForm(&$form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

got it

function is now protected

You have to make sure there is one patch that contains all changes needed.
Your latest patch is only the latest change.
Try again, including all changes from the original patches.

Updated patch

The issue here is that the buildGroupForm namespace is already used at around line 419 of FilterPluginBase.php .

  public function buildGroupForm($form, &$form_state) {
    $item = &$this->options;
    // flip. If the filter was a group, set back to a standard filter.
    $item['is_grouped'] = empty($item['is_grouped']);

    // If necessary, set new defaults:
    if ($item['is_grouped']) {
      $this->build_group_options();
    }

    $form_state['view']->get('executable')->setItem($form_state['display_id'], $form_state['type'], $form_state['id'], $item);

    $form_state['view']->addFormToStack($form_state['form_key'], $form_state['display_id'], $form_state['type'], $form_state['id'], TRUE, TRUE);

    $form_state['view']->cacheSet();
    $form_state['rerender'] = TRUE;
    $form_state['rebuild'] = TRUE;
    $form_state['force_build_group_options'] = TRUE;
  }

renaming the build_group_form method to buildGroupForm throws all sorts of errors. any suggestions on what we should rename this to, to avoid the conflict?

i read the function and picked a more specific name.

Looks wonderful. There are just these two instances.

Committed and pushed to 8.x. Thanks!

Moving to Views for the change notice.

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.