Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 views-buildGroupOptions-2002380-6.patch1.44 KBzschmid
#1 rename_build_group_options-2002380.patch1.01 KBtheladebug

Comments

theladebug’s picture

theladebug commented
Status: Active » Needs review
StatusFileSize
new rename_build_group_options-2002380.patch1.01 KB
nneka’s picture

nneka
she/her
commented
Assigned: Unassigned » nneka
nneka’s picture

nneka
she/her
commented
Assigned: nneka » Unassigned
oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -714,7 +714,7 @@ public function defaultExposeOptions() {
+  function buildGroupOptions() {

Add protected access modifier in front of the function to adher to the new OOP standards.

oenie’s picture

oenie commented
Status: Needs review » Needs work
zschmid’s picture

zschmid commented
Status: Needs work » Needs review
StatusFileSize
new views-buildGroupOptions-2002380-6.patch1.44 KB

Updated patch

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, views-buildGroupOptions-2002380-6.patch, failed testing.

zschmid’s picture

zschmid commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#6: views-buildGroupOptions-2002380-6.patch queued for re-testing.

oenie’s picture

oenie commented
Status: Needs review » Reviewed & tested by the community

Looks fine to me now !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c3b21af and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.