Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 drupal-views_method_rename-2002382-6.patch1.48 KBdanylevskyi
#6 interdiff.txt800 bytesdanylevskyi
#2 views.module-renamed-build_group_submit-2002382-02.patch1.05 KBtoddtomlinson

Comments

toddtomlinson’s picture

toddtomlinson commented
Assigned: Unassigned » toddtomlinson
toddtomlinson’s picture

toddtomlinson commented
StatusFileSize
new views.module-renamed-build_group_submit-2002382-02.patch1.05 KB

Patch attached that renames build_group_submit() to buildGroupSubmit.

toddtomlinson’s picture

toddtomlinson commented
Assigned: toddtomlinson » Unassigned
Status: Active » Needs review
oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -665,7 +665,7 @@ function build_group_validate($form, &$form_state) {
+  function buildGroupSubmit($form, &$form_state) {

Add protected access modifier in front of the function to adher to the new OOP standards.

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Assigned: Unassigned » danylevskyi
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt800 bytes
new drupal-views_method_rename-2002382-6.patch1.48 KB
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
commented
Assigned: danylevskyi » Unassigned
aspilicious’s picture

aspilicious commented
Status: Needs review » Reviewed & tested by the community
somepal’s picture

somepal commented

reviewed,gtg

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Title: Rename Views method build_group_submit() to buildGroupSubmit() » Change notice: Rename Views method build_group_submit() to buildGroupSubmit()
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Rename Views method build_group_submit() to buildGroupSubmit() » Rename Views method build_group_submit() to buildGroupSubmit()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

We'll create a single change notice in #1856630: [Change notice] [META] Rename Views methods to core standards.

Automatically closed -- issue fixed for 2 weeks with no activity.