Rename Views method can_build_group() to canBuildGroup()

Taking this with baldwinlouie.

Patch attached, no testing done, method only appears in one place.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -175,7 +175,7 @@ public function canExpose() { return TRUE; }
+  function canBuildGroup() {

This should be marked as protected

These are the only places the method is used.

Re-rolled as protected.

rename can_build_group to canBuildGroup.

marking as needs review.

Patch re-rolled, tested locally, let's see if I am lucky

Looks good to me now !

Needs a re-roll

curl http://drupal.org/files/rename-can_build_group-views-2002416-11.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1348  100  1348    0     0    481      0  0:00:02  0:00:02 --:--:--   513
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php:175
error: core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.php: patch does not apply

Reroll
Conflict

++<<<<<<< HEAD
 +  function can_build_group() {
 +    return $this->isExposed() && (count($this->operatorOptions()) > 0);
++=======
+   protected function canBuildGroup() {
+     return $this->isExposed() && (count($this->operator_options()) > 0);
++>>>>>>> 11

Resloved

-   function can_build_group() {
 -  protected function canBuildGroup() {
 -    return $this->isExposed() && (count($this->operator_options()) > 0);
++  function canBuildGroup() {
 +    return $this->isExposed() && (count($this->operatorOptions()) > 0);

Empty patch? Re-rolled.

Re-rolling the patch following suggestions

[I am learning about patching but I do not think this is going to be the one; I am happy to try again if someone tells me what needs changing please]

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -175,7 +175,7 @@ public function canExpose() { return TRUE; }
+  function canBuildGroup() {

Should be a protected method.

Re-rolled with protected.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -197,14 +197,14 @@ public function buildOptionsForm(&$form, &$form_state) {
-    if ($this->can_build_group()) {
+    if ($this->canBuildBroup()) {

You made a typo here: Should be canBuildGroup instead

Renamed can_build_group to canBuildGroup. Added protected access modifier as mentioned by dawehner.

Seems fine.

Committed 7d31103 and pushed to 8.x. Thanks!