Rename Views method create_view() to createView()

Taking this with baldwinlouie.

Here's a patch.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::createView().

The standard is {@inheritdoc}, just have a look at #1354: [Obsolete] API documentation and comment standards

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+      throw new WizardException('Attempted to createView with values that have not been validated.');

I guess if we already change this exception message something like "Attempted to create a view with values that have not been validated."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardInterface.phpundefined
@@ -55,6 +55,6 @@ public function validateView(array $form, array &$form_state);
+  function createView(array $form, array &$form_state);

This should be a public method

Re-rolled with the feedback.

#2: 2002434-rename-create_view.patch queued for re-testing.

#6: 2002434-rename-create_view.patch queued for re-testing.

Looks good to me now.

Needs a re-roll

 curl http://drupal.org/files/2002434-rename-create_view_0.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  3652  100  3652    0     0   9835      0 --:--:-- --:--:-- --:--:-- 18728
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php:1161
error: core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.php: patch does not apply

Re-rolled against a recent pull of 8.x (retrieve_validated_view in the original patch changed in core to retrieveValidatedView so it should match in the 'unchanged' lines now).

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -1161,12 +1161,12 @@ public function validateView(array $form, array &$form_state) {
+   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::createView().
...
+  function createView(array $form, array &$form_state) {

public and @inheritdoc

Added, and re-rolled.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/wizard/WizardPluginBase.phpundefined
@@ -198,7 +198,7 @@ public function getSorts() {
   /**
-   * Implements Drupal\views\Plugin\views\wizard\WizardInterface::build_form().
+   * {@inheritdoc}
    */
   function build_form(array $form, array &$form_state) {

Even I don't like this unrelated change ...

If even @dawehner does not like the unrelated change displayed in #16... then lets not do it :)

Re-rolled with inheritDoc only for createView().

Thank you!

Committed 577949f and pushed to 8.x. Thanks!