Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
24 May 2013 at 03:49 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoPatch attached. Tested with a view that has a path, looks for a contextual filter, and has the contextual filter setting of "Page not found" when there's no argument. Test view is (correctly) page not found where there's no argument, tries to show a view if there is an argument.
Comment #3
oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Comment #4
Anonymous (not verified) commentedRe-rolled and added public in front of function name.
Comment #5
dawehnerShouldn't that be better protected?
Comment #6
oenie commented@dawehner: i wasn't sure in which context a method like that would be called, which is why i suggested public before.
Comment #7
dawehnerIt's called in ArgumentPluginBase::default_action()
Comment #8
heddnComment #9
sillygwailoRe-rolled with
protected.Comment #11
sillygwailo#9: 2002460-rename-default_not_found.patch queued for re-testing.
Comment #12
aspilicious commentedComment #13
alexpottCommitted e44d062 and pushed to 8.x. Thanks!