Rename Views method ensure_table() to ensureTable()

# modified: core/modules/views/lib/Drupal/views/ManyToOneHelper.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ManyToOne.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
# modified: core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/query/QueryTest.php
#

#1: ensure_table_rename-2002484.patch queued for re-testing.

index 1209901..5f2078b 100644
--- a/core/modules/views/lib/Drupal/views/ManyToOneHelper.php

@@ -508,7 +508,7 @@ function mark_table($table, $relationship, $alias) {
+  function ensureTable($table, $relationship = null, JoinPluginBase $join = null) {

Add public access modifier in front of the function to adher to the new OOP standards.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -89,14 +89,14 @@ class Sql extends QueryPluginBase {
+  var $distinct = false;
...
+  var $has_aggregate = false;
...
+  var $get_count_optimized = null;

... and many more occurences

Every occurence of NULL, TRUE and FALSE should be uppercase. This patch changed all occurences to lowercase

My bad. Should have stuck with vi instead of new install of phpStorm.

Anyway, this updated patch should have only the ensure_table() -> ensureTable() change.

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -508,7 +508,7 @@ function mark_table($table, $relationship, $alias) {
+  function ensureTable($table, $relationship = NULL, JoinPluginBase $join = NULL) {

Still missing that public access modifier though.

Third time's the charm? :)

Took ownership.

#11 doesn't apply any longer.

re-roll

I have fixed the problem (and tested by installing Drupal and accessing views). I have also rerolled it against the latest tree.

Setting status.

Committed 6345a5c and pushed to 8.x. Thanks!