Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 views-2002498-exposedFormSubmit-8.patch2.47 KBdiarmy
#9 interdiff.txt693 bytesdiarmy
#7 views-2002498-exposedFormSubmit-7.patch2.47 KBdiarmy
#7 interdiff.txt885 bytesdiarmy
#6 views-2002498-exposedFormSubmit-6.patch2.46 KBdiarmy
#2 views-2002498-exposedFormSubmit.patch2.46 KBphenaproxima

Comments

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2002498-exposedFormSubmit.patch2.46 KB

This patch passed the general rendering and exposed form tests on my localhost.

Status: Needs review » Needs work

The last submitted patch, views-2002498-exposedFormSubmit.patch, failed testing.

oenie’s picture

oenie commented 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -271,12 +271,12 @@ function exposed_form_validate(&$form, &$form_state) {
+  function exposedFormSubmit(&$form, &$form_state, &$exclude) {

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/pager/PagerPluginBase.phpundefined
@@ -243,7 +243,7 @@ function exposed_form_alter(&$form, &$form_state) { }
+  function exposedFormSubmit(&$form, &$form_state, &$exclude) { }

Add public access modifier in front of the functions to adher to the new OOP standards.

diarmy’s picture

diarmy commented

Added public access modifier in front of the exposedFormSubmit() function in views

diarmy’s picture

diarmy commented
StatusFileSize
new views-2002498-exposedFormSubmit-6.patch2.46 KB

Whoops! Forgot patch. :)

diarmy’s picture

diarmy commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt885 bytes
new views-2002498-exposedFormSubmit-7.patch2.47 KB

This patch adds in second public modifier. #6 only amended one of them.

Status: Needs review » Needs work

The last submitted patch, views-2002498-exposedFormSubmit-7.patch, failed testing.

diarmy’s picture

diarmy commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt693 bytes
new views-2002498-exposedFormSubmit-8.patch2.47 KB

Public modifier had been placed after 'function' in line 246 of PagerPluginBase.php. It has now been placed before.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Thank you. This looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5202f71 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.