Closed (cannot reproduce)
Project:
Drupal core
Version:
8.0.x-dev
Component:
other
Priority:
Minor
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 11:22 UTC
Updated:
29 Jul 2014 at 22:23 UTC
Jump to comment: Most recent file
Comments
Comment #1
louisjimenez commentedPatch attached
Comment #3
kerasai commented#1: Drupal_core-removed-unused-local-variable-2002728-1.patch queued for re-testing.
Comment #4
kerasai commentedLooks good. Nothing tricky and the testbot is happy.
Comment #5
louisjimenez commentedThanks for reviewing!
Comment #6
alexpottNeeds a reroll as this code has been refactored to
Drupal\Core\Extension\ModuleHandlerComment #7
kerasai commented#1: Drupal_core-removed-unused-local-variable-2002728-1.patch queued for re-testing.
Comment #9
martin107 commentedThis patch has become irrelevant and the issue should be marked complete/invalid.
Results from searching the code base:-
1) module.inc has been removed/renamed.
2) there is only one definition of function module_enable() -- bears no relation to function referred to in the patch.
3) patch removes a single line $schema_store = Drupal::keyValue('system.schema');
searching code base for this line -- shows one occurrence in which the variable is used later in function.
Comment #10
martin107 commentedChanged status after conversation with Cottser