I'm doing a bit of playing which includes periodically starting with a fresh install -- so I noticed that the added line in settings.php which requires "settings_domain_prefix.inc" breaks the install by jumping directly to the DRUPAL_BOOTSTRAP_DATABASE phase before system tables have been created.

I remedied this by simply prefixing the include with a check for SCHEMA_INSTALLED like so:

if (SCHEMA_INSTALLED) require_once './sites/all/modules/domain/domain_prefix/settings_domain_prefix.inc';

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Active » Postponed (maintainer needs more info)

Interesting.

Can you explain what SCHEMA_INSTALLED does and why we should check it rather than just making a note in the INSTALL file?

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

The documentation doesn't help. http://api.drupal.org/api/constant/SCHEMA_INSTALLED/5

This fix should go into the include file itself. Let's not burden settings.php with conditional statements.

file: settings_domain_prefix.inc
file: settings_domain_conf.inc

In both cases, the functions should likely be wrapped in this conditional.

 if (SCHEMA_INSTALLED) {
  _drupal_bootstrap(DRUPAL_BOOTSTRAP_DATABASE);
  _domain_conf_load();
}

But I still don't understand if this is necessary.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented

Still waiting for justification for this feature. Seems like user error to me.

Perhaps simply add to the documentation.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

This is a phantom issue. The cause and solution are both obvious.