Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
views.module
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
24 May 2013 at 18:13 UTC
Updated:
29 Jul 2014 at 22:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
ericthelast commentedI'm working on this issue now.
Comment #2
ericthelast commentedComment #3
ericthelast commentedUpdated all methods & docblocks references.
Comment #5
heddnSeveral tests are failing. Needs investigation.
Comment #6
ericthelast commentedYeah, I've looked into it but honestly I'm at a loss. Not sure where to go from here.
Comment #7
heddnIf we can't figure it out by Thurs night, this would be a good topic for the st louis meetup.
Comment #8
chrisjlee commentedLooks like you need to find the class that it's inheriting. I have no clue either it's hard to tell from the patch.
Comment #9
heddnLet's see if this works. I think the changes in #2 were a little too aggressive and also changed 'render_item'.
Comment #10
ericthelast commentedNice catch Lucas! Thanks for looking into it.
Comment #12
heddnLet's see if this patch will work.
Comment #13
dawehnermissing s in renderItems
Comment #14
dcam commentedSetting status per #13.
Comment #15
heddnAre we sure this should be plural? The actual code calls
return method_exists($this, 'render_item');on line 120.Comment #16
heddnThis patch addresses #13.
Comment #17
heddnComment #18
dawehnerNice!
Comment #19
alexpottCommitted 579780c and pushed to 8.x. Thanks!