Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#10 rename-render_exposed_form-views-2003362-10.patch3.13 KBmariafromatoz
#8 rename-render_exposed_form-views-2003362-8.patch3.63 KBmariafromatoz
#6 rename-render_exposed_form-views-2003362-6.patch3.12 KBmariafromatoz
#3 views-2003362-renderExposedForm.patch3.12 KBphenaproxima

Comments

SpartyDan’s picture

SpartyDan commented

I made a typo in the title:

Rename Views method render_exposed_form()() to renderExposedForm()

Should be:

Rename Views method render_exposed_form() to renderExposedForm()

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: Unassigned » phenaproxima
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Assigned: phenaproxima » Unassigned
Status: Active » Needs review
StatusFileSize
new views-2003362-renderExposedForm.patch3.12 KB

Patch passed general Views rendering tests and exposed form plugin tests on my localhost.

Status: Needs review » Needs work

The last submitted patch, views-2003362-renderExposedForm.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Tests failing. Please investigate and re-roll a patch.

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Needs review
StatusFileSize
new rename-render_exposed_form-views-2003362-6.patch3.12 KB

Patch re-rolled, passed local tests

oenie’s picture

oenie commented
Status: Needs review » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/views/exposed_form/ExposedFormPluginBase.phpundefined
@@ -115,7 +115,7 @@ public function buildOptionsForm(&$form, &$form_state) {
+  function renderExposedForm($block = FALSE) {

Add public access modifier in front of the function to adhere to the new OOP standards.

Apart from that, all occurrences seem to be replaced.

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Needs review
StatusFileSize
new rename-render_exposed_form-views-2003362-8.patch3.63 KB

Let me try again

[edit: it is not going to work, I am having problems with my editor!]

Status: Needs review » Needs work

The last submitted patch, rename-render_exposed_form-views-2003362-8.patch, failed testing.

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Needs review
StatusFileSize
new rename-render_exposed_form-views-2003362-10.patch3.13 KB

Well, maybe the third time is the winner

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks good from the code site. Now the testbot just have to be able to breath again.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename-render_exposed_form-views-2003362-10.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review

#10: rename-render_exposed_form-views-2003362-10.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +Novice, +VDC

The last submitted patch, rename-render_exposed_form-views-2003362-10.patch, failed testing.

mariafromatoz’s picture

mariafromatoz commented
Status: Needs work » Closed (fixed)

I am going to close this issue - I hope this is ok.
The change already appears in the latest version of Drupal 8.x

SpartyDan’s picture

SpartyDan commented
Status: Closed (fixed) » Closed (duplicate)

This issue is duplicate of drupal.org/node/2003346