Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#9 rename_views_method-2003368-8.patch5.39 KBmarlatt
#9 interdiff.txt3.14 KBmarlatt
#8 rename_views_method-2003368-8.patch5.39 KBmarlatt
#8 interdiff.txt3.14 KBmarlatt
#6 views-core-rename-pre_execute-2003368-6.patch8.53 KBSpartyDan
#5 views-core-rename-pre_execute-2003368-5.patch5.69 KBSpartyDan
#2 Rename_Views_method-2003368-2.patch8.52 KBnonprofit

Comments

nonprofit’s picture

nonprofit commented
Assigned: Unassigned » nonprofit
nonprofit’s picture

nonprofit commented
Assigned: nonprofit » Unassigned
Status: Active » Needs review
StatusFileSize
new Rename_Views_method-2003368-2.patch8.52 KB

Patch created.

Status: Needs review » Needs work

The last submitted patch, Rename_Views_method-2003368-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Tests failing. Please investigate and re-roll a patch.

SpartyDan’s picture

SpartyDan commented
Status: Needs work » Needs review
StatusFileSize
new views-core-rename-pre_execute-2003368-5.patch5.69 KB

re-rolled

SpartyDan’s picture

SpartyDan commented
StatusFileSize
new views-core-rename-pre_execute-2003368-6.patch8.53 KB

Previous patch was not complete.

Status: Needs review » Needs work

The last submitted patch, views-core-rename-pre_execute-2003368-6.patch, failed testing.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.14 KB
new rename_views_method-2003368-8.patch5.39 KB 
+++ b/core/modules/views/lib/Drupal/views/ViewExecutable.php
@@ -1166,7 +1166,7 @@ public function execute($display_id = NULL) {
     // Let modules modify the view just prior to executing it.
     $module_handler = \Drupal::moduleHandler();
-    $module_handler->invokeAll('views_pre_execute', array($this));
+    $module_handler->invokeAll('views_preExecute', array($this));

It looks as though changes were made to another function reference outside the scope of the intended change?

Reversed changes to views_pre_execute references and similiar and re-rolled patch.

marlatt’s picture

marlatt commented
StatusFileSize
new interdiff.txt3.14 KB
new rename_views_method-2003368-8.patch5.39 KB

I apologize, the above interdiff was incorrect, here is the patch and interdiff corrected.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Reviewed & tested by the community

Patch in #8 looks good.

Status: Reviewed & tested by the community » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, rename_views_method-2003368-8.patch, failed testing.

marlatt’s picture

marlatt commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#9: rename_views_method-2003368-8.patch queued for re-testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs review » Reviewed & tested by the community

GTG, the re-test passed.

somepal’s picture

somepal commented

reviewed, gtg with #8 rename_views_method-2003368-8.patch

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 022531a and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.