Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 2003484-rename-get_token_values_recursive.patch | 1.7 KB | sillygwailo |
| #2 | 2003484-rename-get_token_values_recursive.patch | 1.69 KB | sillygwailo |
Comments
Comment #1
sillygwailoTaking this with baldwinlouie.
Comment #2
sillygwailoPatch attached.
Comment #4
sillygwailo#2: 2003484-rename-get_token_values_recursive.patch queued for re-testing.
Comment #5
oenie commentedAdd protected access modifier in front of the function to adhere to the new OOP standards.
If the above is fixed, the patch is ok and ready for RTBC.
Comment #6
sillygwailoRe-rolled with protected.
Comment #7
oenie commentedLooks good to me now !
Comment #8
jibranAdding VDC tag.
Comment #9
alexpottCommitted df13368 and pushed to 8.x. Thanks!