Document better that $conf overrides any db setting
| Project: | Drupal |
| Version: | 6.x-dev |
| Component: | documentation |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
When setting theme_default in default.settings.php the documentation does not indicate that once this setting is made active that you cannot change the theme from 'admin/build/themes'. The unexpected behavior of setting this setting and not realizing the results may seem like a bug to a user when they browse to 'admin/build/themes' and try to change the theme. The user can even deactivate the current default theme and hit submit and the theme is no longer showed as active but is still shown as default and it is visible that the theme is still the active theme though no error or other indication is visible. I've been informed that this happens at a "very low level" and that "the UI won't be able to change it." If this were not the case it would be nice for the options in the theme table to be set to '#disabled' to indicate that something else, in this case settings.php, is prohibiting the desired action. Since I have been informed that this is not possible I have attached a patch to default.settings.php. I've marked this as 'patch (code needs work)' as I am uncertain that my explanation is fully ready and would enjoy getting additional input to the subject.
Thanks,
-mpare
| Attachment | Size |
|---|---|
| default.settings.php_.txt | 8.61 KB |
#1
Was this the file you intended to attach? I ask because diff says it is identical to the existing default.settings.php. But perhaps I misunderstand....
#2
Actually this not only applies to the default_theme but any setting overridden here. As the code says:
Emphasis from me. Admittedly this might not be clear enough. But it applies to any setting, so there is no generic way to disable stuff on settings forms when other values are set here.
#3
Retitled.
#4
Err... Sorry, rerolled patch from root. Wasn't getting email notifications in regards to this issue.
#5
I've made additional changes to the "Variable overrides:" paragraph indicating that these changes cannot be changed form the drupal admin interface. My text in regards to theme_default may be redundant now but I think that the additional text I added to the theme_default is still useful however. Please let me know your opinions.
Thanks,
-mpare
#6
- "any changes made to this document" sounds quite inappropriate. We are concerned about the values in the array not the changes in the document :)
- I am not sure we need a specific note about this at the theme... the site name cannot be modified if it is set in the setting.php file as well
#7
Yes, I agree that "any changes made to this document" sounds inappropriate after I reviewed the text a little later. I have changed this to say "Note that any changes made to the variable overrides cannot be changed from the drupal administration interface." In addition I removed the statement about the theme_default.
Thanks,
-mpare
#8
I made some edits to the text, and committed this one. Thanks!
#9
Small typo, so I'm marking RTBC.
#10
Committed, good catch.
#11
Automatically closed -- issue fixed for two weeks with no activity.