[D7] Sequential Nodes

Hello à Darth,
1 . Your files missed documentation.
2 . LINE 7 of sequential_nodes.inc : _sequential_nodes_page_link(): Do not use db_select() for simple static queries, use db_query() instead.
3 . It is not necesary to declare files[] because you do not have the Class into the files sequential_nodes.admin.inc and sequential_nodes.inc

You have many errors, take a look on http://ventral.org/pareview/httpgitdrupalorgsandboxdarthraven2004630git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi,
I found some issues:

1) Implement hook_uninstall()
Create a file called sequential_nodes.install and implement hook_uninstall() to delete all variables stored by sequential_nodes.

2) Names of variables
You should name your variable with a prefix, like 'sequential_nodes_next_link' to avoid namespace collisions.

3) prev-next-link.tpl.php
You should use two spaces instead of tabs.

Thats all for now.
Happy coding.

By the way: user_access() is the default acces callback in hook_menu(). So you don't have to specify it.

manual review:

• _sequential_nodes_page_link(): node access grants are missing on the node query, see https://api.drupal.org/api/drupal/modules!node!node.module/group/node_ac...

This is an access bypass issue and therefore a security blocker. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Very good, looks RTBC to me now. Also removed the review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to sreynen as he might have time to take a final look at this.

Added Review

no objections for more than a week, so ...

Thanks for your contribution, Darth Raven!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.