Files are not in the private dir

what do you mean:

1. If I install private_upload i got a lot of erroes becaue opendir, closedir, is wrong?

If your system doesn't know about opendir:
http://us.php.net/manual/en/function.opendir.php
and closedir:
http://us.php.net/manual/en/function.closedir.php
it's kind of surprising that any of the file handling code works at all.

Have you checked your admin/logs/status page? I suspect there is something up with your 'files' directory.

Can you give beta4 a try? It has some improved status testing methods that might give me more information.

Hi,

On submit or preview of a form, I also receive the "Private Upload: Private checkbox not in form." error. I'm running a relatively new install of 5.5 with beta4.

Function private_upload_form_validate() reports this error. I suspect function private_upload_form_alter() is not injecting the private checkbox properly--I'm learning about how the forms API works as I go here, so perhaps I can offer a fix if I stumble across the solution. I'm finding

          echo "<pre>";
          print_R($form);
          echo "</pre>";

quite useful in seeing the structure of the form for debugging purposes.

Peace

@DesignWork & schultkl: My current working theory is that if you see the "Private Upload: Private checkbox not in form." error, then there is another module that is in conflict with Private Upload. Please try disabling all your non-core modules and see if that fixes the problem for you.

Also, ignore the warning in #11. That will be gone in the next beta.

Hi Starbow,

Unchecking everything in admin/build/modules (except upload and Private Upload) failed to remove the error. I'm still investigating and I'll let you know what I find.

Peace

Hi Starbow,

Since both modules have module weight zero, module upload overrides this private_upload::private_upload_form_alter() assignment, as modules evaluate in alphabetical order:

    303   $form['attachments']['wrapper']['files']['#theme'] = 'private_upload_form';

By the time includes/form.inc::drupal_prepare_form() finishes this code:

    363   foreach (module_implements('form_alter') as $module) {
    364     $function = $module .'_form_alter';
    365     $function($form_id, $form);
    366   }

the value set by module private_upload above is "upload_form_current".

Solution: Setting the weight of the upload module to a value less than private_upload (for example, -1) fixes this issue.

private_upload_form_validate() now displays "Hi Tao" at the top of the screen as a successful validation should.

Peace

Per:

Howto: Update a module's weight
http://drupal.org/node/110238

I've created a file implementing hook private_upload_install() for updating table system when the module is installed. Alternatively, you might incoporate it into private_upload.module.

<?php

/**
 * Implementation of hook_install().
 *
 * Ensures private_upload runs after module upload
 */
function private_upload_install() {

  switch ($GLOBALS['db_type']) {
    case 'mysql':
    case 'mysqli':
      $weight = (int)db_result(db_query("SELECT weight FROM {system} WHERE name = 'upload'"));
      db_query("UPDATE {system} SET weight = %d WHERE name = 'private_upload'", $weight+1);
      break;

    case 'pgsql':
      $weight = (int)db_result(db_query("SELECT weight FROM {system} WHERE name = 'upload'"));
      db_query("UPDATE {system} SET weight = %d WHERE name = 'private_upload'", $weight+1);
      break;
  }
}

Peace

@DesignWork: Ok, I have committed a variation on schultkl's patch to beta5. Please give that a try (be sure to visit the status page to trigger the weight change). I am a little dubious, but if this fixes it, great.

Please try this with beta5. Let's see if it is a module weight problem.

Actually, if you can, please apply this patch - it should have better error messages. If you can't apply this patch, be sure to visit /admin/settings/private_upload before retesting.

Thanks.

Hi Starbow,

At 12:07 PST, I'm unable to download beta5:

Not Found

The requested URL /files/projects/private_upload-5.x-1.0-beta5.tar.gz was not found on this server.

Also, a minor change suggestion--bug 202235 in the release notes:

http://drupal.org/node/202235: schultkl's Fix for migrating private files if same file attached to multiple nodes.

fixed the case when multiple roles have access to a node with a file attachment.

Peace

Hi Starbow,

I tested this patch and it seems to resolve the problem. After visiting admin/settings/private_upload I see the message:

Setting private_upload.module weight to 1

When I visit the private node, I immediately see the private checkbox in the File Attachments area.

BTW--the second chunk of the patch looks strange to me:

@@ -429,15 +436,7 @@

   // get status messages from the requirements hook.
   _private_upload_requirements('runtime', $status);
-
-  // Be sure to go after core upload.module (weight=0).
-  $upload_weight = (int)db_result(db_query("SELECT weight FROM {system} WHERE name = 'upload'"));
-  $private_weight = (int)db_result(db_query("SELECT weight FROM {system} WHERE name = 'private_upload'"));
-  if ($private_weight <= $upload_weight) {
-    drupal_set_message( "Setting private_upload.module weight to ". ($upload_weight+1));
-    db_query("UPDATE {system} SET weight = '%d' WHERE name = 'private_upload'", $upload_weight+1);
-  }
-
+
   // loop through all the file in private folder & collect stats.
   $private_file_count = 0;
   $d = opendir( $private_path );

It seems backwards--it seems to me the patch should add (+) the core upload.module check. I'm relatively new to patching so perhaps I'm confused in this instance.

Peace

@DesignWork

You're describing the same problem I had.

If you're willing and able, please find table system in your database. Look at the weights for records "private_upload" and "upload" (last column). Record private_upload should have a weight that's greater than record upload. If not, please change record private_upload to have a greater weight than record upload. Finally, revisit the node with the error.

Please let me know if that fixes the problem.

It seems you may have tested with beta4, which does not correct the problem. Beta5 doesn't seem to be available just yet but should correct the issue.

Peace

Kevin

Weird that beta5 isn't showing up. I rolled in the patch and did another released as beta6, but it's not showing up yet either. Hmm, I bet the packaging system is just running slow today. If you are chomping at the bit, you can pull a copy of the most recent code from: http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/private_upl...
(Update: the beta packages just showed up).

@schultkl: You are right about the math being wrong in #21. In a patch, any line that starts with '-' is being removed, and any line that starts with '+' is being added. So the lines with the bad math are being removed by the patch.

Hi Starbow, DesignWork,

I just installed a new instance of Drupal 5.5 and module private_upload beta6, and everything works as expected.

Hoping this resolves your issue.

Peace

That's wonderful news Dirk. Wishing you continued success.

Kevin

great