Improve Drupal IRC bot 'seen' command
| Project: | Google Highly Open Participation Contest (GHOP) |
| Component: | Task idea |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Jump to:
Task description: Druplicon is an often used helper bot on #drupal, and other drupal related channels. Its seen? feature is to let the user know when somebody was last on the channels, ie:
snufkin: seen snufkin?
Druplicon: snufkin was last seen on #drupal 0 hours 0 min ago saying 'seen snufkin?'
This task requires two improvements to this feature:
Task 1: if there is a username in the reply string other than the target person check if that person is on the channel and if he, or she is, alter the username to avoid pinging the person. ie: snufkin said yesterday hi chx, how are you doing. now you ask seen snufkin? and Druplicon will reply: "snufkin was last seen on #drupal 20 hours 42 min ago saying 'hi chx, how are you doing.'"
This results in pinging chx unnecessarily. So the task would be to alter chx to chx_noping in the reply string. if he is on the channel.
Resource: original issue http://drupal.org/node/193209
Task 2: Seen reflect /me operations
When you ask Druplicon "seen %username%", it doesn't reflect actions from the /me command....
(11:41:13 AM) litwol: think of how insurances work ;)
(12:33:35 PM) ***litwol giggles
(12:34:58 PM) RobLoach: seen litwol
(12:34:58 PM) Druplicon: litwol was last seen in #drupal 53 min 44 sec ago saying 'think of how insurances work ;)'.
Make this work.
Resource: http://drupal.org/node/199564
Submit patches to BOTH issue queues respectively, primary contacts: Morbus, chx
Disclaimer
I know that two task might be a bit confusing, but these are easy tasks, the only problem might be that at the end the student has to submit his/her patches to both issue queues on the bot issue tracker. But I think they are smart enough to do that :)
#1
Other than that I think the task should indicate that both patches need to be marked RTBC for the task to be completed, this looks good to me.
#2
Yepp, I will include that too. I am now waiting for Morbus to review this task, and then I will put it on the google list.
#3
Be sure to have the task title include something about "irc bot", otherwise it will look very confusing.
#4
good point
#5
I think this title clarifies the task a little better and makes it more of an action. I don't know that having a URL in the title is a good idea since it won't be linkable.
#6
This looked very, very, very easy to me. Too easy for a GHOP task. To quote webchick, "That smells like about 2 lines of code."
This would either (a) need to be made into a harder task, or (b) explain why this is harder than it actually looks.
-cwgordon7
#7
Perhaps it can be merged with this task: Extend Druplicon's functionality.
#8
Seems like a good idea, probably going to be a bit too simple though, as cwgordon said.
#9
At this point, I think it's pretty clear that we have plenty of task slots and that we won't run out. We have several pretty simple tasks, so I'm not worried about having another. The students are doing a pretty good job of taking tasks that are interesting and where they can learn something, instead of just taking all the easy tasks. So, if this idea gets polished up a little, I'm fine making it a task.