When creating a client site, I like to customize the size fully, removing all of the drupal icons. That being the case, I would rather use my theme's favicon in place of the drupal favicon. To do so is simple:
in admin_menu.module, line 357
$output = '<img id="admin_menu_icon" src="' . theme_get_setting('favicon') . '" width="16" height="16" alt="" border="0" />';
This will revert back to the default favicon if no theme favicon is present.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | admin_menu.patch | 708 bytes | sun |
Comments
Comment #1
FreeFox commented+1
I suggest that the administration menu gets a settings page where you can enter the image to be displayed and where you can select what to see. e.g. I don't want to see the logout option, the users option. To not break the style I use I want to be able to make the icons smaller and because they don't look very nice when resized it would be great to select your own images.
But that's not so important. The important thing is that this module exists and I love it. Great job.
Comment #2
sunPlease test attached patch.
Comment #3
sunTest plan:
- Apply above patch.
- Check if the favicon switches, if you alter your theme's settings.
- Check if the favicon is correct after switching to another theme.
- Go to admin/build/block, click on one of the sub-tabs to display blocks for another theme (theme-specific block settings) and verify that the other theme is displayed.
Comment #4
decipheredTested patch and here are my results:
- Apply above patch.
Patch Applied successfully
- Check if the favicon switches, if you alter your theme's settings.
favicon did not switch until I manually flushed the cache.
- Check if the favicon is correct after switching to another theme.
favicon switched as I switched themes
- Go to admin/build/block, click on one of the sub-tabs to display blocks for another theme (theme-specific block settings) and verify that the other theme is displayed.
favicon did not switch as I switched between sub-tabs
Comment #5
sunokay, but did the theme actually switch at all after clicking on a sub-tab?
Comment #6
decipheredYeah, theme changed, as per usual, but the favicon didn't.
Comment #7
sunSince the icon is cached, the remaining issues can't be fixed. However, I think they are minor.
Thanks, committed!
Comment #8
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.