Line 588 should be made to output the tree navigation within a

container the same as the core navigation block - to keep consistent.

new line 588:

    return '<div class="menu"><ul>'. $tree .'</ul></div>';

You are still able to format the book tree navigation different to the core navigation block as this tree is a child of css class 'book-block'.

CommentFileSizeAuthor
#1 book_28.patch558 byteskilles@www.drop.org

Comments

killes@www.drop.org’s picture

killes@www.drop.org commented
StatusFileSize
new book_28.patch558 bytes

Here's the patch.

dries’s picture

dries commented

Where does Drupal core emit a class="menu" ?

jhriggs’s picture

jhriggs commented

Line 89 of menu.module in menu_block():

<code>
  $data['content'] = '<div class="menu">'. theme('menu_tree', $delta) .'</div>' ;

Should the change maybe be made to theme_menu_tree() instead to take care of all of them at once? And if so, should the class be called "tree" rather than "menu"?

budda’s picture

budda
Primary language English
Location Cheshire
commented

Class "tree" would be good. But would this change break any existing themes?
Also - the tree menu is used within the book pages at the footer to show nested pages - so would you want that to be within the same class?

Stefan Nagtegaal’s picture

Stefan Nagtegaal commented

Why don't we remove the menu-<div>??
We can style it using .block-user etc, right?

Stefan.

moshe weitzman’s picture

moshe weitzman commented

Stefan - menus can be used anywhere. the user block is just the most common place to see one. that div is appropriate.

dries’s picture

dries commented

Committed to HEAD.

Anonymous’s picture

(not verified) commented