Failing drupal_write_record() doesn't keep $object's original array form

+1

+1. This looks very good.

Reason: we need people to test this.

Patch broken by a trivial conflict. Here's a re-roll.

As an aside, does this concept code actually work?

function convert_object(&$array) {
  $array = (object) $array;
}

$test = array('a' => 'b');

convert_object($test);

if (is_object($test)) print "PHP clearly handles references in a different way than Java.";

Because that's what this "avoid confusing the caller" code seems to do. Does (object) and (array) casting work in-place in spite of the assignment?

This should be bumped to D7, actually.
Should be fixed there first, then backported

Here is the test for Simpletest module.
I cannot reproduce the situation here: http://drupal.org/node/207170 since drupal_write_record() generate a valid query for core shemas.

class TestCase200824 extends DrupalTestCase {
  function get_info() {
    return array(
      'name' => t('[200824] Failing drupal_write_record() doesn\'t keep $object\'s original array form'),
      'desc' => t('A small bug exists in drupal_write_record() failing to convert an array passed in as $object back to array format should drupal_get_schema() fail for any reason. Although drupal_get_schema() is not meant to return FALSE for any reason drupal_write_record() is still meant to live up to expectation and leave $object in it\'s original state.'),
      'group' => t('Drupal 7 Tests'),
    );
  }
  
  function testIssue() {
    $array = array();
    $object = new stdClass();

    // try to write record into not exsisted table
    drupal_write_record($this->randomName(), $array);
    drupal_write_record($this->randomName(), $object);

    $this->assertTrue(is_array($array), 'Test original array form');
    $this->assertTrue(is_object($object), 'Test original object form');
  }

}

@Vladimir, how is a random name results in valid queries? Or do I misunderstand something here?

The point is:

"Although drupal_get_schema() is not meant to return FALSE for any reason drupal_write_record() is still meant to live up to expectation and leave $object in it's original state."

So if drupal_get_schema() fails (no schema found because of a random name) then drupal_write_record() won't convert "array" to "object" in any case.

I re-discovered this bug, applied the patch from this issue to D6, reviewed it, and it looks fine to me.

Vladimir's test case is currently sitting in this issue, not in a file anywhere. We do not yet have a plan for where to put test cases for individual bug fixes/issues. Once we figure that out, we can put his test case there.

Committed to Drupal 6, still to be committed to 7!

Committed to CVS HEAD. Thanks.

I'm update the component to 'tests' so we can still write a test for this (if necessary).

I discussed this with Gabor yesterday. Vladimir already wrote a test case, posted in this issue. I wasn't sure where to put it in the filesystem. It's a test for a particular bug fix, in this case in the includes/ directory. Can we have includes/includes.test? Or should we create a directory of per-issue test cases like ./tests/200824.test? Or something else? we;re going to end up having a lot of "here's the test for the bug reported in issue #xyz" and we need a consistent strategy for handling them.

Test for drupal_write_record() here: #353918: drupal_write_record writes empty string instead of empty serialized array