GHOP #103: send a mail to a role

Patch attached. Needs review.

* please make use of the latest workflow-ng token API. Read the docs about it (http://drupal.org/node/156754) and make sure to work with the latest workflow-ng code (branch DRUPAL-5)

* use the user_roles() parameter to get members only, instead of manually removing anonymous users.

* use array_filter() to filter the results of the checkbox. Best do this before return the settings of the action.

* text: "Select which roles should receive this email." Roles can't receive mails, but the users do.

* Sending such masses of mails might be to resource intensive for a lot of sites with many users. For this case we would need a mail queuing system, but this isn't the scope of this task. However please add a note, so that people can decide on their on and use this action or not. E.g. add it to the description of your action. Or elsewhere, but people should not overlook this!

Patch re-rolled.

Thanks, we are already closer.. :)

* Don't use workflow_ng_token_get_used_arguments(), use workflow_ng_token_get_settings() instead (new API) - this will make your code simpler.

* The warning in the checkboxes description can be overlooked too easily. I suggest, we add a paragraph on top of the checkboxes showing the warning - I think this would be recognized by much more users.

* Another thing I overlooked before: Use http://api.drupal.org/api/constant/DRUPAL_AUTHENTICATED_RID/5 instead of 2.

Patch re-rolled again. Hopefully this is it :) .

again, we are closer. Though there are some points left that need to be addressed:

* minor, but usually first comes the action implementation function workflow_ng_action_mail_to_users_of_role() and then the form configuration - please also adapt the order like this. Also add a short comment at least to first function like it's done for all other actions.

* Don't use the token integration on the recipients array. Token replacements can be only done with string values!

* Then let's improve your code a bit. You could eliminate the last foreach - just build $result in the above if/else, then use one while loop, in which you send out the mails.

* You have added now array_filter, so you can remove the check " if ($chose_role) {" when iterating over $recipients. So now you build up $recipient_roles from $recipients, which isn't necessary any more. Use in_array() to check for authenticated users.

* Your second query uses a %s placeholder, which doesn't fit for this case. Just add the imploded role ids directly to the query - they need not be checked as it are only ids, that stem from the database - it's no user input.

Ok, I got up early with the hope that I could get feedback on this without waiting 24 hours. Patch re-rolled.

hm, or work more carefully then it needs less reviews..

* you have got some debug statements in your code

* coding style: while( -> while (

* move the while() out of the if/else statement. The while is identical for both cases, so don't duplicate it!

Ok, patch rerolled. So sorry about the debug code left in there :(. I guess this is what I get for trying to work on drupal early in the morning... Thank you for being so patient with me through this process :).

-cwgordon7

thanks for your work! good job, committed :)