GHOP #110: Write Simpletest tests for admin/build/modules functionality

OK, I'm attaching the .test file containing the 3 testcases.
I can't generate diffs to break the test at the moment, but I can suggest how to break the tests:

Test 1:
- http://api.drupal.org/api/function/system_modules_submit/6
Change

drupal_set_message(t('The configuration options have been saved.'));

to some other message.
- Comment out (same file)

drupal_install_modules($new_modules);

Test 2:
- http://api.drupal.org/api/function/system_modules_confirm_form/6
Change the second parameter of confirm_form in the following block of code.

  if ($form) {
    // Set some default form values
    $form = confirm_form(
      $form,
      t('Some required modules must be enabled'),
      'admin/build/modules',
      t('Would you like to continue with enabling the above?'),
      t('Continue'),
      t('Cancel'));
    return $form;
  }

- Before that block of code, set $form to false
- http://api.drupal.org/api/function/system_modules_submit/6
Remove the return from

  // If there where unmet dependencies and they haven't confirmed don't process
  // the submission yet. Store the form submission data needed later.
  if ($dependencies) {
    if (!isset($form_state['values']['confirm'])) {
      $form_state['storage'] = array($dependencies, $form_state['values']['status']);
      return;

Test 3:
- http://api.drupal.org/api/function/system_modules_submit/6
Change

drupal_set_message(t('The configuration options have been saved.'));

to some other message.
- Break/remove the uninstall hook for a module so that tables are not removed properly
- http://api.drupal.org/api/function/system_modules_uninstall_submit/6
Change
drupal_set_message(t('The selected modules have been uninstalled.'));

Thanks :)
I'm attaching a revised set of tests that incorporates your comments.

Fair enough, I'll get right on it :)

And revised. :)

I guess I should set this as well (it was set automatically before, how odd) :)

Smartys, great work. A few comments: string concat code style, there is always a space on both sides of a dot but there is no space between a quote (single or double) and a dot. So $edit['status['. $module .']' you lack 1-1 space. I would run coder module over this just to make sure there are no more code style violations. HEAD of coder works w/ D6.

Thanks a lot. :)
I just checked out the coder module from CVS and ran it (I had to move the .test file into the simpletest folder and give it a .php extension), but it didn't find any mistakes. I've made your changes though and the fixed version is attached.

It would be my pleasure :)

Committed.