GHOP #112: Write Simpletest tests for Actions for content

link to task: http://code.google.com/p/google-highly-open-participation-drupal/issues/...

note - in IRC I suggested writing the aid as md5(callback) for readability, testing all 6 actions, and comparing $node->status, etc to an int rather than a string.

This code comment needs fixing:

// Set action id to "publish post".

Also, there is a random $i in various calls like:

 $node->body      = $this->randomName(32 + $i)

why $action rather than $this->actionName($action)? you shouldn't concat like that in t()
t('Check to make sure the "'. $action .'" action is fired.'));
look at your code below: t('Action %action has been unassigned.', array('%action' => $this->actionName($action)))

that's a better model

      // Action should NOT work.
      $this->assertTrue(!$this->actionWorked($action, $node2)

why not:

     $this->assertFalse($this->actionWorked($action, $node2)

There is something weird going on with trigger/actions when trying to sequentially run several sequentially. Also, we found this bug - need to patch to make this work on PHP4.4: http://drupal.org/node/203846

So - this issue demonstrates the value of this exercise - we turned up 2 core bugs! Thanks cwgordon7

some trivial patches that break the tests

I did a quick fix on a couple of the error messages, and re-rolled this in patch form (diffed from the simpletest module directory). Looks good to me.

@cwgordon7: please post the final version to the GHOP queue