GHOP #114: A filter to make all other filters obsolete.

#1: It wouldn't. The token module does not do filtering; even if it did, it would be inadequate. This is something more; it may be possible to include tokens, but they are not critical to the task.

Claimed by Corsix.

THIS IS JUST SO COMPLETELY AWESOME! I'M SO EXCITED TO SEE HOW THIS TURNS OUT!

-cwgordon7

Edit: Just for the record, I'm the one who's going to be maintaining this after it's finished, so no worries about an unmaintained chunk of code, people. :D

Major problem:

Undefined index: in sites\all\modules\flexifilter\flexifilter.module on line 461. This error occurs when there are no conditions inside of something that contains conditions (which should default to false).

Minor problems:

-Add a notice when there are no conditions that it defaults to false.
-Replace the "Help text will go here." text with actual help text.
-Edit, delete, and disable/enable should each have a column of the table for themselves. EDIT: I mean on the overview page, not in the database.

<?php
     /*
        Optimisation case; the loop is skipped if none of the components do anything
        in this step. Also helps prevent niaeve infinite loops like this one:
        while (text contains "example") replace "example" with "e.g."
        As the replacement would only run in processing, the while loop would loop
        forever in preparation.
      */
?>

Would probably be better as

<?php
     /**
      * Optimization case; the loop is skipped if none of the components do anything
      * in this step. Also helps prevent naive infinite loops like this one:
      * while (text contains "example") replace "example" with "e.g."
      * As the replacement would only run in processing, the while loop would loop
      * forever in preparation.
      */
?>

-The "Number of iterations before abort" field should check to make sure the value is_numeric. "Abc" can be entered without an error.
Note: These minor problems are very nitpicky, and I probably wouldn't ask you to do them if you didn't have a major problem to fix as well.

However, this looks just plain awesome!

-cwgordon7

As much as I hate to set this back to code needs work, here I am, doing it. Here's the bug I found:

1) Add a new filter. Do some stuff, then, instead of clicking "create", click "create and edit".

2) Do some more stuff, and then click "create".

3) You're redirected to the overview page, where you notice your filter has been duplicated: the first version is like a snapshot from step 1, the second version is like a snapshot from step 2. This is wrong.

The reason this is happening appears to be because even when you click "create and edit" you remain on the add form, and thus when you click "create" again, it attempts to create a new one. This should be relatively simple to solve by redirecting to the edit form upon clicking "create and edit". This appears to be the only problem I could find.

Hopefully this will be done soon and we can get a release out! This is so exciting!

Oops! Another bug:

It appears that $constant is undefined on line 165 of flexifilter.components.inc in the line

<?php
      return $constant == $op;
?>

You probably meant to use $step, not $constant.

Ok, after discussion with dmitrig01, this is rtbc. I'll be checking it into cvs shortly.

Checked into cvs! This is closed! Awesomeful! Setting to closed, not fixed, to save webchick work ;)