Several issues arise when you make a subscription defunct:

1) You can no longer edit the subscription. An error "Subscription does not exist or was deleted subid=1" occurs when you click to edit. The subscription should remain editable.

2) When lm_paypal_subscribe() is called, an error "lm_paypal_subscribe cannot find subscription: 1" occurs. This is because the function searches for $subid and status = Live. There should be no search for status; instead, the function should return a message like "This subscription is inactive" if that is the case.

(This brings up another issue: I don't like the term "defunct." "Defunct" is, IMO, too strong a word. I prefer the terms "Inactive" and "Active.")

3) Interestingly, the name of the defunct subscription is shown at lm_paypal/subscribe/$subid when the error in #2 (above) is displayed. This should read "Invalid Subscription."

Comments

buttonwillowsix’s picture

buttonwillowsix commented

There should be a better way to mothball a subscription for later use.

jack.ho’s picture

jack.ho commented

This is a temporarily fix to this problem. Defunct subscription, say its subid=1, can be still accessed via the link below:

http://www.example.com/admin/lm_paypal/subscriptions/new/1

On the editing page, you can alter its status from "defunct" to "live".

Then save the changes.

mrtoner’s picture

mrtoner commented

Sure, that works around the editing problem, but not the errors in coding and UI. Still not suitable for deployment, IMO.

john franklin’s picture

john franklin commented
Status: Active » Closed (won't fix)

Closing all 5.x and earlier issues. If this is still an issue, please reopen and update with 6.x or 7.x details.